Skip to content

Loading…

Move timezone field from Account page to Contact page so that changes to it are saved #28

Merged
merged 2 commits into from

2 participants

@shawnpwalsh

Fixes issue reported by numerous users where timezone changes would not
save
http://www.projectpier.org/node/3337
http://www.projectpier.org/node/4044

shawnpwalsh added some commits
@shawnpwalsh shawnpwalsh Move timezone from Account page to Contact page
Fixes issue reported by numerous users where timezone changes would not
save
http://www.projectpier.org/node/3337
http://www.projectpier.org/node/4044
204fcdf
@shawnpwalsh shawnpwalsh Display error on page when uploading file revision
If there is an error during uploading of a file revision, display it to
the page
9aa2c64
@phpfreak phpfreak merged commit 8aa0aef into phpfreak:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 31, 2012
  1. @shawnpwalsh

    Move timezone from Account page to Contact page

    shawnpwalsh committed
    Fixes issue reported by numerous users where timezone changes would not
    save
    http://www.projectpier.org/node/3337
    http://www.projectpier.org/node/4044
  2. @shawnpwalsh

    Display error on page when uploading file revision

    shawnpwalsh committed
    If there is an error during uploading of a file revision, display it to
    the page
View
1 application/controllers/AccountController.class.php
@@ -76,7 +76,6 @@ function edit_profile() {
'fax_number' => $user->getFaxNumber(),
'mobile_number' => $user->getMobileNumber(),
'home_number' => $user->getHomeNumber(),
- 'timezone' => $user->getTimezone(),
'is_admin' => $user->getIsAdmin(),
'auto_assign' => $user->getAutoAssign(),
'use_LDAP' => $user->getUseLDAP(),
View
1 application/controllers/ContactsController.class.php
@@ -190,6 +190,7 @@ function edit() {
'company_id' => $contact->getCompanyId(),
'title' => $contact->getTitle(),
'email' => $contact->getEmail(),
+ 'timezone' => $contact->getTimezone(),
'office_number' => $contact->getOfficeNumber(),
'fax_number' => $contact->getFaxNumber(),
'mobile_number' => $contact->getMobileNumber(),
View
1 application/plugins/files/views/add_revision.php
@@ -14,6 +14,7 @@
<?php } // if ?>
<h2><?php echo lang('file'); ?>: <?php echo $file->getObjectName(true); ?></h2>
<form action="<?php echo $file->getAddRevisionUrl() ?>" method="post" enctype="multipart/form-data">
+ <?php tpl_display(get_template_path('form_errors')) ?>
<div id="fileRevisionComment">
<?php echo label_tag(lang('revision comment'), 'fileRevisionComment') ?>
<?php echo textarea_field('revision[comment]', array_var($revision_data, 'comment'), array('class' => 'short', 'id' => 'fileRevisionComment')) ?>
View
5 application/views/contacts/add_contact.php
@@ -125,6 +125,11 @@
</div>
<div>
+ <?php echo label_tag(lang('timezone'), 'contactFormTimezone', true)?>
+ <?php echo select_timezone_widget('contact[timezone]', array_var($contact_data, 'timezone'), array('id' => 'contactFormTimezone', 'class' => 'long')) ?>
+ </div>
+
+ <div>
<fieldset>
<legend><?php echo lang('avatar') ?></legend>
<?php if ($contact->hasAvatar()) { ?>
View
5 application/views/user/add_user.php
@@ -53,11 +53,6 @@
<?php echo lang('user locale desc') ?>
</div>
- <div>
- <?php echo label_tag(lang('timezone'), 'userFormTimezone', true)?>
- <?php echo select_timezone_widget('user[timezone]', array_var($user_data, 'timezone'), array('id' => 'userFormTimezone', 'class' => 'long')) ?>
- </div>
-
<?php if ($user->isNew() || logged_user()->isAdministrator()) { ?>
<fieldset>
<legend><?php echo lang('password') ?></legend>
Something went wrong with that request. Please try again.