Do not trigger UnusedFormalParameter with some magic methods #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelpichler
added a commit
that referenced
this pull request
Nov 10, 2014
Do not trigger UnusedFormalParameter with some magic methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPMD incorrectly detects some parameters as unused for magic methods (ie. __call), but it is not possible to remove them from the signature since they are required by PHP.
This P/R makes the UnusedFormalParameter ignore parameters for magic methods with the following names:
The functions have been filtered using two criterias, first one being that they have at least one argument, second that the signature is dictated by PHP and implementations cannot remove the parameters from the signature even when unused.