Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website links and use common library for PHPMD and Pdepend #624

Closed

Conversation

kylekatarnls
Copy link
Member

This need first #623 to be merged and this to be rebased on master.

@kylekatarnls kylekatarnls force-pushed the feature/website-builder-library branch from 254662c to 180924e Compare July 9, 2019 13:58
@kylekatarnls kylekatarnls marked this pull request as ready for review July 9, 2019 14:09
@kylekatarnls kylekatarnls changed the title Feature/website builder library [WIP] Feature/website builder library Jul 12, 2019
@kylekatarnls
Copy link
Member Author

I have to check page content handling how to make absolute links working: #631

@kylekatarnls kylekatarnls requested a review from tvbeek July 12, 2019 09:39
@kylekatarnls kylekatarnls changed the title [WIP] Feature/website builder library Fix website links and use common library for PHPMD and Pdepend Jul 12, 2019
src/site/rst/about.rst Outdated Show resolved Hide resolved
@kylekatarnls kylekatarnls requested a review from tvbeek July 16, 2019 10:18
tvbeek
tvbeek previously approved these changes Jul 16, 2019
@ravage84 ravage84 self-requested a review July 23, 2019 22:47
@ravage84 ravage84 added this to the 2.8.0 milestone Jul 28, 2019
@kylekatarnls
Copy link
Member Author

@tvbeek @ravage84 Is there something to change here?

tvbeek
tvbeek previously approved these changes Aug 13, 2019
@tvbeek
Copy link
Member

tvbeek commented Aug 13, 2019

@tvbeek @ravage84 Is there something to change here?

No, just missed that I need to re review it 😃

@kylekatarnls
Copy link
Member Author

Use #711 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants