Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace xdebug with phpdbg for code coverage #669

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Replace xdebug with phpdbg for code coverage #669

merged 1 commit into from
Aug 22, 2019

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Aug 22, 2019

Not as much gain as with pdepend, but for consistency I think it's worth it.

Before:

image

After:

image

ravage84
ravage84 reviewed Aug 22, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
@ravage84 ravage84 added this to the 2.7.1 milestone Aug 22, 2019
kylekatarnls
kylekatarnls requested changes Aug 22, 2019
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep coverage.xml. In an other PR we should send it to codecov.io or codeclimate.com to get an online view of the coverage.

@jakzal
Copy link
Contributor Author

jakzal commented Aug 22, 2019

coverage.xml was never here. It should be introduced in a separate PR.

@kylekatarnls
Copy link
Member

Indeed, it was PDepend only.

@kylekatarnls kylekatarnls merged commit d365af4 into phpmd:master Aug 22, 2019
@jakzal jakzal deleted the phpdbg branch August 22, 2019 16:48
@kylekatarnls kylekatarnls modified the milestones: 2.7.1, 2.8.0 Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravage84 ravage84 ravage84 approved these changes

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
Dependencies Testing
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakzal @kylekatarnls @ravage84