Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for apply and notApply tests #791

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Improve error message for apply and notApply tests #791

merged 4 commits into from
Jul 21, 2020

Conversation

kylekatarnls
Copy link
Member

Type: testing feature
Breaking change: no

Before when a violation count error occurred:

PHPMD\Report::addRuleViolation(PHPMD\RuleViolation Object (...)) was not expected to be called.

Now:

testRuleDoesNotApplyToKeyReferencePair.php failed:
Expected 0 violations
But 1 violation raised:
  - line 26 on Variable $fooBar

@kylekatarnls kylekatarnls merged commit e90ce77 into master Jul 21, 2020
@kylekatarnls kylekatarnls deleted the feature/fix-import-phpunit-exception branch July 21, 2020 19:34
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkVaughn MarkVaughn MarkVaughn approved these changes

@tvbeek tvbeek tvbeek approved these changes

@ravage84 ravage84 Awaiting requested review from ravage84

Assignees

@ravage84 ravage84

Labels
Testing
Milestone
2.x (unspecific)
Development

Successfully merging this pull request may close these issues.
4 participants
@kylekatarnls @MarkVaughn @tvbeek @ravage84