Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trims whitespaces in PMA_HOSTS, PMA_PORTS and PMA_VERBOSES #184

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

deeky666
Copy link
Contributor

@deeky666 deeky666 commented Aug 3, 2018

I encountered a problem when configuring hosts via yaml multiline:

environment:
    PMA_HOSTS: >
        host_a,
        host_b,
        host_c

This config resolves to PMA_HOSTS=host_a, host_b, host_c which leads to not being able to login to host_b and host_c because of leading whitespaces.

It would be really useful to be able to list hosts in multiple lines for readability and also version control diffing.

Therefore this patch simply trims each value in PMA_HOSTS, PMA_PORTS and PMA_VERBOSES.

@nijel nijel merged commit b1e2062 into phpmyadmin:master Sep 1, 2018
@nijel
Copy link
Contributor

nijel commented Sep 1, 2018

Merged, thanks for your contribution!

@nijel nijel self-assigned this Sep 1, 2018
@deeky666
Copy link
Contributor Author

deeky666 commented Sep 3, 2018

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants