Handle a possible curl init error

Signed-off-by: William Desportes <williamdes@wdes.fr>
phpmyadmin · Mar 11, 2021 · f3e3230 · f3e3230
1 parent 129c131
commit f3e3230
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 25 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -50,36 +50,11 @@ parameters:
 			count: 1
 			path: src/Controller/Component/GithubApiComponent.php
 
-		-
-			message: "#^Parameter \\#1 \\$ch of function curl_setopt expects resource, resource\\|false given\\.$#"
-			count: 5
-			path: src/Controller/Component/GithubApiComponent.php
-
-		-
-			message: "#^Parameter \\#1 \\$ch of function curl_exec expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/Controller/Component/GithubApiComponent.php
-
-		-
-			message: "#^Parameter \\#1 \\$ch of function curl_error expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/Controller/Component/GithubApiComponent.php
-
-		-
-			message: "#^Parameter \\#1 \\$ch of function curl_close expects resource, resource\\|false given\\.$#"
-			count: 3
-			path: src/Controller/Component/GithubApiComponent.php
-
 		-
 			message: "#^Parameter \\#1 \\$json of function json_decode expects string, string\\|true given\\.$#"
 			count: 1
 			path: src/Controller/Component/GithubApiComponent.php
 
-		-
-			message: "#^Parameter \\#1 \\$ch of function curl_getinfo expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/Controller/Component/GithubApiComponent.php
-
 		-
 			message: "#^Method App\\\\Controller\\\\Component\\\\GithubApiComponent\\:\\:createIssue\\(\\) has parameter \\$data with no value type specified in iterable type array\\.$#"
 			count: 1

diff --git a/src/Controller/Component/GithubApiComponent.php b/src/Controller/Component/GithubApiComponent.php
@@ -135,6 +135,11 @@ public function sendRequest(
     ): array {
         Log::debug('Request-url: ' . $url);
         $curlHandle = curl_init($url);
+        if ($curlHandle === false) {
+            Log::error('Curl init error for: ' . $url);
+
+            return ['', 0];
+        }
         curl_setopt($curlHandle, CURLOPT_CUSTOMREQUEST, $method);
         $header = ['Accept: application/json'];
         if ($access_token !== '') {