Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only public interface #74

Closed
nijel opened this issue Dec 5, 2014 · 4 comments
Closed

Read only public interface #74

nijel opened this issue Dec 5, 2014 · 4 comments
Assignees

Comments

@nijel
Copy link
Contributor

nijel commented Dec 5, 2014

Once we sort out performance issues, the tool should provide public read only interface.

@devenbansod
Copy link
Member

Hi @nijel, do we still want users to first 'Login with Github' and then we decide which interface (read-only or current) to show based on whether the user has commit access to phpmyadmin/phpmyadmin repo?

OR let the tool's read-only interface be accessible to everyone without logging in and for editing/updating the reports, the user has to login?

@ibennetch
Copy link
Member

ibennetch commented Jun 25, 2017 via email

@nijel
Copy link
Contributor Author

nijel commented Jun 27, 2017

The problem I see right now is that we link error reports from GitHub and it's not really possible for non team member to figure out details. That's why I was proposing this. Having this behind GitHub authentication would block it from being indexed by bots, what is probably desirable.

Alternative approach might be to include more information in the GitHub comments, so that going into the report is not necessary, but I'm not sure this is good approach either.

We don't store any IP address or private URLs, unless user enters this into the error message, so there really should not be anything to leak (that was one of intentions when creating error reports, to not store any sensitive data there).

PS: Anyway we should not collect anything what can be considered personal data, otherwise we would be hit by GDPR.

@ibennetch
Copy link
Member

ibennetch commented Jun 28, 2017 via email

devenbansod added a commit to devenbansod/error-reporting-server that referenced this issue Jun 30, 2017
Fix phpmyadmin#74

* Allow read-only access to reports and incidents views for non-team developers

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
devenbansod added a commit to devenbansod/error-reporting-server that referenced this issue Jun 30, 2017
Fix phpmyadmin#74

* Allow read-only access to reports and incidents views for non-team developers

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
devenbansod added a commit to devenbansod/error-reporting-server that referenced this issue Jun 30, 2017
Fix phpmyadmin#74

* Allow read-only access to reports and incidents views for non-team developers

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants