Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Github issue state #155

Merged
merged 2 commits into from Jun 15, 2017
Merged

Follow Github issue state #155

merged 2 commits into from Jun 15, 2017

Conversation

devenbansod
Copy link
Member

@devenbansod devenbansod commented Jun 14, 2017

Fix #98

  • Follow Github issue state
  • Add tests for Github events controller

To setup:

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

@codecov
Copy link

codecov bot commented Jun 14, 2017

Codecov Report

Merging #155 into master will increase coverage by 3.23%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     46.22%   49.46%   +3.23%     
- Complexity      297      321      +24     
============================================
  Files            25       26       +1     
  Lines          1404     1494      +90     
============================================
+ Hits            649      739      +90     
  Misses          755      755

Fix phpmyadmin#98

Add tests for Github events controller

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@nijel
Copy link
Contributor

nijel commented Jun 15, 2017

Looks good, can you please include the deployment instructions (which are in the pull request) into README.md?

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@nijel nijel merged commit 256f5f7 into phpmyadmin:master Jun 15, 2017
@nijel
Copy link
Contributor

nijel commented Jun 15, 2017

Merged, thanks for your contribution!

@devenbansod devenbansod deleted the fix_98 branch June 16, 2017 04:52
@nijel nijel self-assigned this Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants