Refactoring in plugin properties to group the properties and methods …

…in the abstract. Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
phpmyadmin · Dec 24, 2013 · 036ff4e · 036ff4e
1 parent 0943134
commit 036ff4e
Show file tree

Hide file tree

Showing 3 changed files with 161 additions and 322 deletions.
diff --git a/libraries/properties/plugins/ExportPluginProperties.class.php b/libraries/properties/plugins/ExportPluginProperties.class.php
@@ -20,41 +20,6 @@
  */
 class ExportPluginProperties extends PluginPropertyItem
 {
-    /**
-     * Text
-     *
-     * @var string
-     */
-    private $_text;
-
-    /**
-     * Extension
-     *
-     * @var string
-     */
-    private $_extension;
-
-    /**
-     * Options
-     *
-     * @var OptionsPropertyRootGroup
-     */
-    private $_options;
-
-    /**
-     * Options text
-     *
-     * @var string
-     */
-    private $_optionsText;
-
-    /**
-     * MIME Type
-     *
-     * @var string
-     */
-    private $_mimeType;
-
     /**
      * Whether to force or not
      *
@@ -65,130 +30,6 @@ class ExportPluginProperties extends PluginPropertyItem
 
     /* ~~~~~~~~~~~~~~~~~~~~ Getters and Setters ~~~~~~~~~~~~~~~~~~~~ */
 
-
-    /**
-     * Returns the property item type of either an instance of
-     *  - OptionsPropertyOneItem ( f.e. "bool", "text", "radio", etc ) or
-     *  - OptionsPropertyGroup   ( "root", "main" or "subgroup" )
-     *  - PluginPropertyItem     ( "export", "import", "transformations" )
-     *
-     * @return string
-     */
-    public function getItemType()
-    {
-        return "export";
-    }
-
-    /**
-     * Gets the text
-     *
-     * @return string
-     */
-    public function getText()
-    {
-        return $this->_text;
-    }
-
-    /**
-     * Sets the text
-     *
-     * @param string $text text
-     *
-     * @return void
-     */
-    public function setText($text)
-    {
-        $this->_text = $text;
-    }
-
-    /**
-     * Gets the extension
-     *
-     * @return string
-     */
-    public function getExtension()
-    {
-        return $this->_extension;
-    }
-
-    /**
-     * Sets the extension
-     *
-     * @param string $extension extension
-     *
-     * @return void
-     */
-    public function setExtension($extension)
-    {
-        $this->_extension = $extension;
-    }
-
-    /**
-     * Gets the options
-     *
-     * @return OptionsPropertyRootGroup
-     */
-    public function getOptions()
-    {
-        return $this->_options;
-    }
-
-    /**
-     * Sets the options
-     *
-     * @param OptionsPropertyRootGroup $options options
-     *
-     * @return void
-     */
-    public function setOptions($options)
-    {
-        $this->_options = $options;
-    }
-
-    /**
-     * Gets the options text
-     *
-     * @return string
-     */
-    public function getOptionsText()
-    {
-        return $this->_optionsText;
-    }
-
-    /**
-     * Sets the options text
-     *
-     * @param string $optionsText optionsText
-     *
-     * @return void
-     */
-    public function setOptionsText($optionsText)
-    {
-        $this->_optionsText = $optionsText;
-    }
-
-    /**
-     * Gets the MIME type
-     *
-     * @return string
-     */
-    public function getMimeType()
-    {
-        return $this->_mimeType;
-    }
-
-    /**
-     * Sets the MIME type
-     *
-     * @param string $mimeType MIME type
-     *
-     * @return void
-     */
-    public function setMimeType($mimeType)
-    {
-        $this->_mimeType = $mimeType;
-    }
-
     /**
      * Gets the force file parameter
      *

diff --git a/libraries/properties/plugins/ImportPluginProperties.class.php b/libraries/properties/plugins/ImportPluginProperties.class.php
@@ -19,166 +19,4 @@
  */
 class ImportPluginProperties extends PluginPropertyItem
 {
-    /**
-     * Text
-     *
-     * @var string
-     */
-    private $_text;
-
-    /**
-     * Extension
-     *
-     * @var string
-     */
-    private $_extension;
-
-    /**
-     * Options
-     *
-     * @var OptionsPropertyRootGroup
-     */
-    private $_options;
-
-    /**
-     * Options text
-     *
-     * @var string
-     */
-    private $_optionsText;
-
-    /**
-     * MIME Type
-     *
-     * @var string
-     */
-    private $_mimeType;
-
-
-    /* ~~~~~~~~~~~~~~~~~~~~ Getters and Setters ~~~~~~~~~~~~~~~~~~~~ */
-
-
-    /**
-     * Returns the property item type of either an instance of
-     *  - OptionsPropertyOneItem ( f.e. "bool", "text", "radio", etc ) or
-     *  - OptionsPropertyGroup   ( "root", "main" or "subgroup" )
-     *  - PluginPropertyItem     ( "export", "import", "transformations" )
-     *
-     * @return string
-     */
-    public function getItemType()
-    {
-        return "import";
-    }
-
-    /**
-     * Gets the text
-     *
-     * @return string
-     */
-    public function getText()
-    {
-        return $this->_text;
-    }
-
-    /**
-     * Sets the text
-     *
-     * @param string $text text
-     *
-     * @return void
-     */
-    public function setText($text)
-    {
-        $this->_text = $text;
-    }
-
-    /**
-     * Gets the extension
-     *
-     * @return string
-     */
-    public function getExtension()
-    {
-        return $this->_extension;
-    }
-
-    /**
-     * Sets the extension
-     *
-     * @param string $extension extension
-     *
-     * @return void
-     */
-    public function setExtension($extension)
-    {
-        $this->_extension = $extension;
-    }
-
-    /**
-     * Gets the options
-     *
-     * @return OptionsPropertyRootGroup
-     */
-    public function getOptions()
-    {
-        return $this->_options;
-    }
-
-    /**
-     * Sets the options
-     *
-     * @param OptionsPropertyRootGroup $options options
-     *
-     * @return void
-     */
-    public function setOptions($options)
-    {
-        $this->_options = $options;
-    }
-
-    /**
-     * Gets the options text
-     *
-     * @return string
-     */
-    public function getOptionsText()
-    {
-        return $this->_optionsText;
-    }
-
-    /**
-     * Sets the options text
-     *
-     * @param string $optionsText options text
-     *
-     * @return void
-     */
-    public function setOptionsText($optionsText)
-    {
-        $this->_optionsText = $optionsText;
-    }
-
-    /**
-     * Gets the MIME type
-     *
-     * @return string
-     */
-    public function getMimeType()
-    {
-        return $this->_mimeType;
-    }
-
-    /**
-     * Sets the MIME type
-     *
-     * @param string $mimeType MIME type
-     *
-     * @return void
-     */
-    public function setMimeType($mimeType)
-    {
-        $this->_mimeType = $mimeType;
-    }
-}
-?>
+}