Create drop table partition page

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
phpmyadmin · Dec 1, 2020 · 0c38913 · 0c38913
1 parent b64be69
commit 0c38913
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 10 deletions.
diff --git a/libraries/classes/Controllers/Table/PartitionController.php b/libraries/classes/Controllers/Table/PartitionController.php
@@ -78,23 +78,32 @@ public function check(): void
 
     public function drop(): void
     {
-        global $containerBuilder, $sql_query;
-
         $partitionName = $_POST['partition_name'] ?? '';
 
         if (strlen($partitionName) === 0) {
             return;
         }
 
-        $sql_query = sprintf(
-            'ALTER TABLE %s DROP PARTITION %s;',
-            Util::backquote($this->table),
-            Util::backquote($partitionName)
-        );
+        [$result, $query] = $this->model->drop($this->db, $this->table, $partitionName);
+
+        if ($result) {
+            $message = Generator::getMessage(
+                __('Your SQL query has been executed successfully.'),
+                $query,
+                'success'
+            );
+        } else {
+            $message = Generator::getMessage(
+                __('Error'),
+                $query,
+                'error'
+            );
+        }
 
-        /** @var SqlController $controller */
-        $controller = $containerBuilder->get(SqlController::class);
-        $controller->index();
+        $this->render('table/partition/drop', [
+            'partition_name' => $partitionName,
+            'message' => $message,
+        ]);
     }
 
     public function optimize(): void

diff --git a/libraries/classes/Table/Partition.php b/libraries/classes/Table/Partition.php
@@ -55,4 +55,18 @@ public function check(string $db, string $table, string $partition): array
 
         return [$rows, $query];
     }
+
+    public function drop(string $db, string $table, string $partition): array
+    {
+        $query = sprintf(
+            'ALTER TABLE %s DROP PARTITION %s;',
+            Util::backquote($table),
+            Util::backquote($partition)
+        );
+
+        $this->dbi->selectDb($db);
+        $result = $this->dbi->tryQuery($query);
+
+        return [(bool) $result, $query];
+    }
 }
diff --git a/templates/table/partition/drop.twig b/templates/table/partition/drop.twig
@@ -0,0 +1,5 @@
+<div class="container-fluid">
+  <h2>{% trans 'Drop partition' %}</h2>
+
+  {{ message|raw }}
+</div>