Skip to content

Commit

Permalink
Update session upload progress bug comment in import_status.php
Browse files Browse the repository at this point in the history
  • Loading branch information
mynetx committed Jun 9, 2013
1 parent a2593c0 commit 1ac9560
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions import_status.php
Expand Up @@ -7,17 +7,15 @@

/* PHP 5.4 stores upload progress data only in the default session.
* After calling session_name(), we won't find the progress data anymore.
*
* https://bugs.php.net/bug.php?id=64075
*
* The bug should be somewhere in
* https://github.com/php/php-src/blob/master/ext/session/session.c#L2342
* Until this is fixed, we need to load the default session to load the data.
* As we cannot load the phpMyAdmin-session after that, we will try to do
* an internal POST request to call ourselves in a new instance.
* That POST request grabs the transmitted upload data and stores them.
*
* TODO: The internal HTTP request may fail if the DNS name cannot be resolved
* or if a firewall blocks outgoing requests on the used port.
* Until this is fixed, we need to load the default session to load the data,
* export the upload progress information from there,
* and re-import after switching to our session.
*/

if (version_compare(PHP_VERSION, '5.4.0', '>=')
Expand Down

0 comments on commit 1ac9560

Please sign in to comment.