"javascript:" is not needed here

phpmyadmin · Sep 25, 2011 · 29a41fc · 29a41fc
1 parent 0c2f7f1
commit 29a41fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/libraries/navigation_header.inc.php b/libraries/navigation_header.inc.php
@@ -87,7 +87,7 @@
         }
         echo '<a href="' . $anchor . '&amp;no_js=true"'
             .' title="' . __('Query window') . '"';
-        echo ' onclick="javascript:if (window.parent.open_querywindow()) return false;"';
+        echo ' onclick="if (window.parent.open_querywindow()) return false;"';
         echo '>' . $query_frame_link_text . '</a>' . "\n";
     } // end if ($server != 0)
 

diff --git a/querywindow.php b/querywindow.php
@@ -87,23 +87,23 @@
     $tabs['sql']['icon']   = 'b_sql.png';
     $tabs['sql']['text']   = __('SQL');
     $tabs['sql']['fragment']   = '#';
-    $tabs['sql']['attr']   = 'onclick="javascript:PMA_querywindowCommit(\'sql\');return false;"';
+    $tabs['sql']['attr']   = 'onclick="PMA_querywindowCommit(\'sql\');return false;"';
     $tabs['sql']['active'] = (bool) ($querydisplay_tab == 'sql');
     $tabs['import']['icon']   = 'b_import.png';
     $tabs['import']['text']   = __('Import files');
     $tabs['import']['fragment']   = '#';
-    $tabs['import']['attr']   = 'onclick="javascript:PMA_querywindowCommit(\'files\');return false;"';
+    $tabs['import']['attr']   = 'onclick="PMA_querywindowCommit(\'files\');return false;"';
     $tabs['import']['active'] = (bool) ($querydisplay_tab == 'files');
     $tabs['history']['icon']   = 'b_bookmark.png';
     $tabs['history']['text']   = __('SQL history'); 
     $tabs['history']['fragment']   = '#';
-    $tabs['history']['attr']   = 'onclick="javascript:PMA_querywindowCommit(\'history\');return false;"';
+    $tabs['history']['attr']   = 'onclick="PMA_querywindowCommit(\'history\');return false;"';
     $tabs['history']['active'] = (bool) ($querydisplay_tab == 'history');
 
     if ($GLOBALS['cfg']['QueryWindowDefTab'] == 'full') {
         $tabs['all']['text']   = __('All');
         $tabs['all']['fragment']   = '#';
-        $tabs['all']['attr']   = 'onclick="javascript:PMA_querywindowCommit(\'full\');return false;"';
+        $tabs['all']['attr']   = 'onclick="PMA_querywindowCommit(\'full\');return false;"';
         $tabs['all']['active'] = (bool) ($querydisplay_tab == 'full');
     }
 }