Early exit in buildHttpQuery()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
phpmyadmin · Mar 12, 2023 · 384cccc · 384cccc
1 parent 31ec124
commit 384cccc
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/libraries/classes/Url.php b/libraries/classes/Url.php
@@ -228,7 +228,7 @@ public static function getCommonRaw(array $params = [], $divider = '?', $encrypt
 
         $query = self::buildHttpQuery($params, $encrypt);
 
-        if (($divider !== '?' && $divider !== '&') || strlen($query) > 0) {
+        if (($divider !== '?' && $divider !== '&') || $query !== '') {
             return $divider . $query;
         }
 
@@ -241,6 +241,10 @@ public static function getCommonRaw(array $params = [], $divider = '?', $encrypt
      */
     public static function buildHttpQuery($params, $encrypt = true): string
     {
+        if ($params === []) {
+            return '';
+        }
+
         $GLOBALS['config'] ??= null;
 
         $separator = self::getArgSeparator();
@@ -320,7 +324,7 @@ public static function getArgSeparator($encode = 'none'): string
             $arg_separator = (string) ini_get('arg_separator.input');
             if (str_contains($arg_separator, ';')) {
                 $separator = ';';
-            } elseif (strlen($arg_separator) > 0) {
+            } elseif ($arg_separator !== '') {
                 $separator = $arg_separator[0];
             } else {
                 $separator = '&';