Use type=date, type=time for DATE and TIME fields

(cannot use for DATETIME and TIMESTAMP because of CURRENT_TIMESTAMP)
phpmyadmin · Aug 18, 2013 · 3d34161 · 3d34161
1 parent 0a0b404
commit 3d34161
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/libraries/insert_edit.lib.php b/libraries/insert_edit.lib.php
@@ -1171,15 +1171,18 @@ function PMA_getHTMLinput($column, $column_name_appendix, $special_chars,
         )
     );
 
+    $input_type = 'text';
     $the_class = 'textfield';
-    if ($column['pma_type'] == 'date') {
+    if ($column['pma_type'] === 'date') {
         $the_class .= ' datefield';
-    } elseif ($column['pma_type'] == 'datetime'
-        || substr($column['pma_type'], 0, 9) == 'timestamp'
+        $input_type = 'date';
+    } elseif ($column['pma_type'] === 'datetime'
+        || substr($column['pma_type'], 0, 9) === 'timestamp'
     ) {
         $the_class .= ' datetimefield';
+    } elseif ($column['pma_type'] === 'time') {
+        $input_type = 'time';
     }
-    $input_type = 'text';
     $input_min_max = false;
     if (in_array(
         $column['True_Type'],
@@ -1196,7 +1199,8 @@ function PMA_getHTMLinput($column, $column_name_appendix, $special_chars,
     return '<input type="' . $input_type . '"'
         . ' name="fields'. $column_name_appendix . '"'
         . ' value="' . $special_chars . '" size="' . $fieldsize . '"'
-        . ($input_min_max !== false ? $input_min_max : '')
+        . ($input_min_max !== false ? ' ' . $input_min_max : '')
+        . ($input_type === 'time' ? ' step="1"' : '')
         . ' class="' . $the_class . '" ' . $unnullify_trigger
         . ' tabindex="' . ($tabindex + $tabindex_for_value). '"'
         . ' id="field_' . ($idindex) . '_3" />';