Merge branch 'QA_4_9' into QA_5_0

phpmyadmin · Oct 17, 2019 · 5698fb2 · 5698fb2
2 parents 2efeb11 + 22b0425
commit 5698fb2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -47,6 +47,7 @@ phpMyAdmin - ChangeLog
 - issue #15499 Fix unparenthesized php deprecation
 - issue #15482 Fix URL encoding plus sign (+) in the table or DB name when configuring foreign keys
 - issue #14898 Fixed bottom table in list in left panel blocked by horizontal scroll bar
+- issue #15161 Fix text area overflows its parent element on "Query" page
 
 4.9.1 (2019-09-20)
 - issue #15313 Added support for Twig 2

diff --git a/js/database/qbe.js b/js/database/qbe.js
@@ -28,7 +28,15 @@ AJAX.registerTeardown('database/qbe.js', function () {
 });
 
 AJAX.registerOnload('database/qbe.js', function () {
-    Functions.getSqlEditor($('#textSqlquery'), {}, 'both');
+    Functions.getSqlEditor($('#textSqlquery'), {}, 'none');
+
+    $('#tblQbe').width($('#tblQbe').parent().width());
+    $('#tblQbeFooters').width($('#tblQbeFooters').parent().width());
+    $('#tblQbe').resize(function () {
+        var newWidthTblQbe = $('#textSqlquery').next().width();
+        $('#tblQbe').width(newWidthTblQbe);
+        $('#tblQbeFooters').width(newWidthTblQbe);
+    });
 
     /**
      * Ajax handler to check the corresponding 'show' checkbox when column is selected

diff --git a/libraries/classes/Database/Qbe.php b/libraries/classes/Database/Qbe.php
@@ -1804,7 +1804,7 @@ public function getSelectionForm()
         $html_output .= Url::getHiddenInputs(['db' => $this->_db]);
         // get SQL query
         $html_output .= '<div class="floatleft desktop50">';
-        $html_output .= '<fieldset>';
+        $html_output .= '<fieldset id="tblQbe">';
         $html_output .= '<legend>'
             . sprintf(
                 __('SQL query on database <b>%s</b>:'),
@@ -1824,7 +1824,7 @@ public function getSelectionForm()
         $html_output .= '</textarea>';
         $html_output .= '</fieldset>';
         // displays form's footers
-        $html_output .= '<fieldset class="tblFooters">';
+        $html_output .= '<fieldset class="tblFooters" id="tblQbeFooters">';
         $html_output .= '<input type="hidden" name="submit_sql" value="1">';
         $html_output .= '<input class="btn btn-primary" type="submit" value="' . __('Submit Query') . '">';
         $html_output .= '</fieldset>';