replace isset to empty

IF statement ! isset($this->uiprefs) was causing issue.

Private property 'uiprefs' is initialized to empty array, so ! isset($this->uiprefs) is always FALSE;
It's not hopefull, so I replace ! isset($this->uiprefs) to empty($this->uiprefs) to fix #17617 bug;

Fixes #17617
Closes #17644

Signed-off-by: Atomu Oku <atomu.work@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

ChangeLog

@@ -19,6 +19,7 @@ phpMyAdmin - ChangeLog
 - issue #17584 It's now possible to browse a database that includes two % in its name
 - issue        Fix PHP 8.2 deprecated string interpolation syntax
 - issue        Some languages are now correctly detected from the HTTP header
+- issue #17617 Sorting is correctly remembered when $cfg['RememberSorting'] is true
 
 5.2.0 (2022-05-10)
 - issue #16521 Upgrade Bootstrap to version 5

libraries/classes/Table.php

@@ -1867,7 +1867,7 @@ protected function loadUiPrefs(): void
      */
     public function getUiProp($property)
     {
-        if (! isset($this->uiprefs)) {
+        if (empty($this->uiprefs)) {
             $this->loadUiPrefs();
         }
 
@@ -1937,7 +1937,7 @@ public function getUiProp($property)
      */
     public function setUiProp($property, $value, $tableCreateTime = null)
     {
-        if (! isset($this->uiprefs)) {
+        if (empty($this->uiprefs)) {
             $this->loadUiPrefs();
         }
 
@@ -1984,7 +1984,7 @@ public function setUiProp($property, $value, $tableCreateTime = null)
      */
     public function removeUiProp($property)
     {
-        if (! isset($this->uiprefs)) {
+        if (empty($this->uiprefs)) {
             $this->loadUiPrefs();
         }
 

phpstan-baseline.neon

@@ -8320,11 +8320,6 @@ parameters:
 			count: 1
 			path: libraries/classes/Table.php
 
-		-
-			message: "#^Property PhpMyAdmin\\\\Table\\:\\:\\$uiprefs \\(array\\) in isset\\(\\) is not nullable\\.$#"
-			count: 3
-			path: libraries/classes/Table.php
-
 		-
 			message: "#^Property PhpMyAdmin\\\\Table\\:\\:\\$uiprefs type has no value type specified in iterable type array\\.$#"
 			count: 1

psalm-baseline.xml

@@ -12908,11 +12908,6 @@
     </PossiblyNullArgument>
   </file>
   <file src="libraries/classes/Table.php">
-    <DocblockTypeContradiction occurrences="3">
-      <code>isset($this-&gt;uiprefs)</code>
-      <code>isset($this-&gt;uiprefs)</code>
-      <code>isset($this-&gt;uiprefs)</code>
-    </DocblockTypeContradiction>
     <InvalidReturnStatement occurrences="1">
       <code>$tableAutoIncrement ?? ''</code>
     </InvalidReturnStatement>