Fix PHP 7 possible binding ambiguity

Signed-off-by: Marc Delisle <marc@infomarc.info>
phpmyadmin · Jul 26, 2015 · 6be170e · 6be170e
1 parent da0630a
commit 6be170e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -5,6 +5,7 @@ phpMyAdmin - ChangeLog
 - issue #1808 "Improve table structure" generates invalid SQL
 - bug         Once checked "Show only active" checkbox is always checked
 - issue #1813 Delete rows using "Check All" is broken
+- Fix PHP 7 possible binding ambiguity
 
 4.4.12.0 (2015-07-20)
 - bug       Saved chart image does not have a proper name or an extension

diff --git a/libraries/tbl_info.inc.php b/libraries/tbl_info.inc.php
@@ -96,7 +96,8 @@
     foreach ($create_options as $each_create_option) {
         $each_create_option = explode('=', $each_create_option);
         if (isset($each_create_option[1])) {
-            $$each_create_option[0]    = $each_create_option[1];
+            // ensure there is no ambiguity for PHP 5 and 7
+            ${$each_create_option[0]} = $each_create_option[1];
         }
     }
     // we need explicit DEFAULT value here (different from '0')