Skip to content

Commit 88c72dc

Browse files
committed
Improve URL filtering in url.php
Signed-off-by: Michal Čihař <michal@cihar.com>
1 parent bf9ad3a commit 88c72dc

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

libraries/core.lib.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -845,6 +845,10 @@ function PMA_linkURL($url)
845845
function PMA_isAllowedDomain($url)
846846
{
847847
$arr = parse_url($url);
848+
// Avoid URLs without hostname or with credentials
849+
if (empty($arr['host']) || ! empty($arr['user']) || ! empty($arr['pass'])) {
850+
return false;
851+
}
848852
$domain = $arr["host"];
849853
$domainWhiteList = array(
850854
/* Include current domain */

0 commit comments

Comments
 (0)