Clarify logic

Signed-off-by: Marc Delisle <marc@infomarc.info>
phpmyadmin · Jun 21, 2015 · a03936a · a03936a
1 parent b6ab6c4
commit a03936a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/libraries/Tracker.class.php b/libraries/Tracker.class.php
@@ -542,7 +542,7 @@ static public function getTrackedData($dbname, $tablename, $version)
         $ddl_date_from = $date = date('Y-m-d H:i:s');
 
         $ddlog = array();
-        $i = 0;
+        $first_iteration = true;
 
         // Iterate tracked data definition statements
         // For each log entry we want to get date, username and statement
@@ -552,15 +552,15 @@ static public function getTrackedData($dbname, $tablename, $version)
                 $username  = /*overload*/mb_substr(
                     $log_entry, 20, /*overload*/mb_strpos($log_entry, "\n") - 20
                 );
-                if ($i == 0) {
+                if ($first_iteration) {
                     $ddl_date_from = $date;
+                    $first_iteration = false;
                 }
                 $statement = rtrim(/*overload*/mb_strstr($log_entry, "\n"));
 
                 $ddlog[] = array( 'date' => $date,
                                   'username'=> $username,
                                   'statement' => $statement );
-                $i++;
             }
         }
 
@@ -570,7 +570,7 @@ static public function getTrackedData($dbname, $tablename, $version)
         $dml_date_from = $date_from;
 
         $dmlog = array();
-        $i = 0;
+        $first_iteration = true;
 
         // Iterate tracked data manipulation statements
         // For each log entry we want to get date, username and statement
@@ -580,15 +580,15 @@ static public function getTrackedData($dbname, $tablename, $version)
                 $username  = /*overload*/mb_substr(
                     $log_entry, 20, /*overload*/mb_strpos($log_entry, "\n") - 20
                 );
-                if ($i == 0) {
+                if ($first_iteration) {
                     $dml_date_from = $date;
+                    $first_iteration = false;
                 }
                 $statement = rtrim(/*overload*/mb_strstr($log_entry, "\n"));
 
                 $dmlog[] = array( 'date' => $date,
                                   'username' => $username,
                                   'statement' => $statement );
-                $i++;
             }
         }