Extract common part from if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
phpmyadmin · Jan 6, 2022 · a4cb490 · a4cb490
1 parent 01438e9
commit a4cb490
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/libraries/classes/DatabaseInterface.php b/libraries/classes/DatabaseInterface.php
@@ -446,11 +446,10 @@ static function ($a, $b) {
         // If permissions are wrong on even one database directory,
         // information_schema does not return any table info for any database
         // this is why we fall back to SHOW TABLE STATUS even for MySQL >= 50002
-        if (empty($tables)) {
+        if ($tables === []) {
+            $sql = 'SHOW TABLE STATUS FROM ' . Util::backquote($database);
             if ($table || ($tbl_is_group === true) || $table_type) {
-                $sql = 'SHOW TABLE STATUS FROM '
-                    . Util::backquote($database)
-                    . ' WHERE';
+                $sql .= ' WHERE';
                 $needAnd = false;
                 if ($table || ($tbl_is_group === true)) {
                     if (is_array($table)) {
@@ -488,9 +487,6 @@ static function ($a, $b) {
                         $sql .= " `Comment` != 'VIEW'";
                     }
                 }
-            } else {
-                $sql = 'SHOW TABLE STATUS FROM '
-                    . Util::backquote($database);
             }
 
             $each_tables = $this->fetchResult($sql, 'Name', null, $link);