bug #1805102, TextareaAutoSelect issues

phpmyadmin · Oct 20, 2007 · ad8dc8e · ad8dc8e
1 parent 6342e82
commit ad8dc8e
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -34,6 +34,9 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
 - it should not be possible to move or copy a table to information_schema
 - bug #1814733 win: copy db to mixed name db fails
 - bug #1777249 [display] Remove horizontal lines in navigation panel
+- bug #1805102 [display] TextareaAutoSelect issues: set this parameter
+  default value to false to help cut&paste from a terminal window; also
+  set focus to the textarea
 
 2.11.1.2 (2007-10-17)
 - fixed XSS in server_status.php, thanks to Omer Singer, The DigiTrust Group

diff --git a/js/querywindow.js b/js/querywindow.js
@@ -12,6 +12,11 @@ function PMA_querywindowCommit(tab)
     return false;
 }
 
+function PMA_querywindowSetFocus()
+{
+    document.getElementById('sqlquery').focus();
+}
+
 function PMA_querywindowResize()
 {
     // for Gecko

diff --git a/libraries/config.default.php b/libraries/config.default.php
@@ -1772,7 +1772,7 @@
  *
  * @global boolean $cfg['TextareaAutoSelect']
  */
-$cfg['TextareaAutoSelect'] = true;
+$cfg['TextareaAutoSelect'] = false;
 
 /**
  * textarea size (columns) for CHAR/VARCHAR

diff --git a/querywindow.php b/querywindow.php
@@ -183,6 +183,12 @@
         'function'  => 'PMA_querywindowResize',
     );
 }
+// always set focus to the textarea
+$js_events[] = array(
+    'object'    => 'window',
+    'event'     => 'load',
+    'function'  => 'PMA_querywindowSetFocus',
+);
 
 /**
  * start HTTP/HTML output