Bug Undefined index submit_type

Signed-off-by: Marc Delisle <marc@infomarc.info>
phpmyadmin · Jan 27, 2015 · b25e20f · b25e20f
1 parent f20406e
commit b25e20f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -7,6 +7,7 @@ phpMyAdmin - ChangeLog
 - bug #4729 Display original field when using "Relational display column" option and display column is empty
 - bug #4734 Default values for binary fields do not support binary values
 - bug #4736 Changing display options breaks query highlighting
+- bug       Undefined index submit_type
 
 4.3.8.0 (2015-01-24)
 - bug       Undefined constant PMA_DRIZZLE

diff --git a/libraries/insert_edit.lib.php b/libraries/insert_edit.lib.php
@@ -1738,9 +1738,10 @@ function PMA_getParamsForUpdateOrInsert()
             ? $_REQUEST['where_clause']
             : array($_REQUEST['where_clause']);
         $using_key  = true;
-        $is_insert  = $_REQUEST['submit_type'] == 'insert'
+        $is_insert  = isset($_REQUEST['submit_type']) 
+                      && ($_REQUEST['submit_type'] == 'insert'
                       || $_REQUEST['submit_type'] == 'showinsert'
-                      || $_REQUEST['submit_type'] == 'insertignore';
+                      || $_REQUEST['submit_type'] == 'insertignore');
     } else {
         // new row => use indexes
         $loop_array = array();
@@ -1752,7 +1753,8 @@ function PMA_getParamsForUpdateOrInsert()
         $using_key  = false;
         $is_insert  = true;
     }
-    $is_insertignore  = $_REQUEST['submit_type'] == 'insertignore';
+    $is_insertignore  = isset($_REQUEST['submit_type'])
+        && $_REQUEST['submit_type'] == 'insertignore';
     return array($loop_array, $using_key, $is_insert, $is_insertignore);
 }