Merge pull request #17608 from MauricioFauth/sidebar-index-links

Fix preview SQL modal not working inside Index modal Fixes #17606
phpmyadmin · Jun 16, 2022 · b6ba539 · b6ba539
2 parents dbf52a9 + bf2add8
commit b6ba539
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 25 deletions.
diff --git a/js/src/functions.js b/js/src/functions.js
@@ -3438,7 +3438,7 @@ Functions.indexDialogModal = function (routeUrl, url, title, callbackSuccess, ca
                     .insertAfter('#index_header');
                 var $editIndexDialog = $('#indexDialogModal');
                 if ($editIndexDialog.length > 0) {
-                    $editIndexDialog.dialog('close');
+                    $editIndexDialog.modal('hide');
                 }
                 $('div.no_indexes_defined').hide();
                 if (callbackSuccess) {

diff --git a/js/src/navigation.js b/js/src/navigation.js
@@ -444,26 +444,6 @@ $(function () {
         }
     );
 
-    /** New index */
-    $(document).on('click', '#pma_navigation_tree li.new_index a.ajax', function (event) {
-        event.preventDefault();
-        var url = $(this).attr('href').substr(
-            $(this).attr('href').indexOf('?') + 1
-        ) + CommonParams.get('arg_separator') + 'ajax_request=true';
-        var title = Messages.strAddIndex;
-        Functions.indexEditorDialog(url, title);
-    });
-
-    /** Edit index */
-    $(document).on('click', 'li.index a.ajax', function (event) {
-        event.preventDefault();
-        var url = $(this).attr('href').substr(
-            $(this).attr('href').indexOf('?') + 1
-        ) + CommonParams.get('arg_separator') + 'ajax_request=true';
-        var title = Messages.strEditIndex;
-        Functions.indexEditorDialog(url, title);
-    });
-
     /** New view */
     $(document).on('click', 'li.new_view a.ajax', function (event) {
         event.preventDefault();

diff --git a/libraries/classes/Controllers/Table/IndexesController.php b/libraries/classes/Controllers/Table/IndexesController.php
@@ -147,6 +147,7 @@ private function displayForm(Index $index): void
             'add_fields' => $add_fields,
             'create_edit_table' => isset($_POST['create_edit_table']),
             'default_sliders_state' => $GLOBALS['cfg']['InitialSlidersState'],
+            'is_from_nav' => isset($_POST['is_from_nav']),
         ]);
     }
 }
diff --git a/templates/footer.twig b/templates/footer.twig
@@ -1,4 +1,3 @@
-{{ include('modals/index_dialog_modal.twig') -}}
 {% if not is_ajax %}
   </div>
 {% endif %}

diff --git a/templates/navigation/tree/node.twig b/templates/navigation/tree/node.twig
@@ -35,6 +35,10 @@
 
       {% if node_is_container %}
         &nbsp;<a class="hover_show_full" href="{{ url(text_link.route, text_link.params) }}">{{ node.name }}</a>
+      {% elseif 'index' in node.classes %}
+        <a class="hover_show_full" href="{{ url(text_link.route) }}" data-post="{{ get_common(text_link.params|merge({'is_from_nav': true})) }}" title="{{ text_link.title }}">
+          {{- node.displayName ?? node.realName -}}
+        </a>
       {% else %}
         <a class="hover_show_full{{ text_link.is_ajax ? ' ajax' }}" href="{{ url(text_link.route, text_link.params) }}" title="{{ text_link.title }}">
           {{- node.displayName ?? node.realName -}}

diff --git a/templates/table/index_form.twig b/templates/table/index_form.twig
@@ -5,6 +5,9 @@
     class="ajax">
 
     {{ get_hidden_inputs(form_params) }}
+    {% if is_from_nav %}
+      <input type="hidden" name="do_save_data" value="1">
+    {% endif %}
 
     <fieldset class="pma-fieldset" id="index_edit_fields">
         <div class="index_info">
@@ -237,6 +240,10 @@
         </div>
     </fieldset>
     <fieldset class="pma-fieldset tblFooters">
+        <button class="btn btn-primary" type="submit">{% trans 'Go' %}</button>
         <button class="btn btn-secondary" type="submit" id="preview_index_frm">{% trans 'Preview SQL' %}</button>
     </fieldset>
 </form>
+{% if is_from_nav %}
+  {{ include('modals/preview_sql_modal.twig') }}
+{% endif %}
diff --git a/test/classes/FooterTest.php b/test/classes/FooterTest.php
@@ -7,7 +7,6 @@
 use ArrayIterator;
 use PhpMyAdmin\ErrorHandler;
 use PhpMyAdmin\Footer;
-use PhpMyAdmin\Template;
 
 use function json_encode;
 
@@ -125,7 +124,7 @@ public function testAjax(): void
         $footer = new Footer();
         $footer->setAjax(true);
         $this->assertEquals(
-            (new Template())->render('modals/index_dialog_modal'),
+            '',
             $footer->getDisplay()
         );
     }
@@ -164,7 +163,7 @@ public function testMinimal(): void
         $footer = new Footer();
         $footer->setMinimal();
         $this->assertEquals(
-            (new Template())->render('modals/index_dialog_modal') . "  </div>\n  </body>\n</html>\n",
+            "  </div>\n  </body>\n</html>\n",
             $footer->getDisplay()
         );
     }