Fix execute routine page not working when not in a modal

Fixes #18441 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
phpmyadmin · May 30, 2023 · b908461 · b908461
1 parent 746a34c
commit b908461
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -41,6 +41,7 @@ phpMyAdmin - ChangeLog
 - issue        Fix duplicate query params in the SQL message card
 - issue #18314 Fix dragged row in index form
 - issue #17392 Fix the actions not being hidden in the Triggers, Routines, Events pages
+- issue #18441 Fix execute routine page not working when not in a modal
 
 5.2.1 (2023-02-07)
 - issue #17522 Fix case where the routes cache file is invalid

diff --git a/templates/database/routines/execute_form.twig b/templates/database/routines/execute_form.twig
@@ -1,4 +1,4 @@
-<form action="{{ url('/database/routines') }}" method="post" class="rte_form ajax" onsubmit="return false">
+<form action="{{ url('/database/routines') }}" method="post" class="rte_form">
   <input type="hidden" name="item_name" value="{{ routine['item_name'] }}">
   <input type="hidden" name="item_type" value="{{ routine['item_type'] }}">
   {{ get_hidden_inputs(db) }}

diff --git a/test/classes/Database/RoutinesTest.php b/test/classes/Database/RoutinesTest.php
@@ -970,6 +970,10 @@ public function providerGetExecuteForm1(): array
         ];
 
         return [
+            [
+                $data,
+                '<form action="index.php?route=/database/routines&server=0&lang=en" method="post" class="rte_form">',
+            ],
             [
                 $data,
                 'name="item_name"',
@@ -1109,6 +1113,10 @@ public function providerGetExecuteForm2(): array
         ];
 
         return [
+            [
+                $data,
+                '<form action="index.php?route=/database/routines&server=0&lang=en" method="post" class="rte_form">',
+            ],
             [
                 $data,
                 'name="execute_routine"',