Fix visual issue for table column comments in dark theme

Removes custom CSS for column comments. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
phpmyadmin · Nov 30, 2023 · b9fbad6 · b9fbad6
1 parent 803fbc1
commit b9fbad6
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 33 deletions.
diff --git a/public/themes/bootstrap/scss/_common.scss b/public/themes/bootstrap/scss/_common.scss
@@ -167,12 +167,6 @@ td .icon {
   width: 100%;
 }
 
-.tblcomment {
-  font-size: 70%;
-  font-weight: normal;
-  color: #009;
-}
-
 .error {
   border: 1px solid maroon !important;
   margin-left: 2px;

diff --git a/public/themes/metro/scss/_common.scss b/public/themes/metro/scss/_common.scss
@@ -502,12 +502,6 @@ img.lightbulb {
   width: 100%;
 }
 
-.tblcomment {
-  font-size: 70%;
-  font-weight: normal;
-  color: #009;
-}
-
 /* disabled text */
 .disabled {
   color: #666;

diff --git a/public/themes/original/scss/_common.scss b/public/themes/original/scss/_common.scss
@@ -201,12 +201,6 @@ label.error {
   width: 100%;
 }
 
-.tblcomment {
-  font-size: 70%;
-  font-weight: normal;
-  color: #009;
-}
-
 /* disabled text */
 
 .disabled {

diff --git a/public/themes/pmahomme/scss/_common.scss b/public/themes/pmahomme/scss/_common.scss
@@ -375,12 +375,6 @@ img.lightbulb {
   width: 100%;
 }
 
-.tblcomment {
-  font-size: 70%;
-  font-weight: normal;
-  color: #009;
-}
-
 // disabled text
 .disabled {
   color: #666;

diff --git a/resources/templates/display/results/comment_for_row.twig b/resources/templates/display/results/comment_for_row.twig
@@ -1,10 +1,10 @@
-{% if comments_map[table_name] is defined
-    and comments_map[table_name][column_name] is defined %}
-    <br><span class="tblcomment" title="{{ comments_map[table_name][column_name] }}">
-        {% if comments_map[table_name][column_name]|length > limit_chars %}
-            {{ comments_map[table_name][column_name]|slice(0, limit_chars) }}…
-        {% else %}
-            {{ comments_map[table_name][column_name] }}
-        {% endif %}
-    </span>
+{% if comments_map[table_name] is defined and comments_map[table_name][column_name] is defined %}
+  <br>
+  <small class="text-body-secondary" title="{{ comments_map[table_name][column_name] }}">
+    {% if comments_map[table_name][column_name]|length > limit_chars %}
+      {{ comments_map[table_name][column_name]|slice(0, limit_chars) }}…
+    {% else %}
+      {{ comments_map[table_name][column_name] }}
+    {% endif %}
+  </small>
 {% endif %}