Disallow the use of console in JavaScript files

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
phpmyadmin · Jun 7, 2019 · c63356d · c63356d
1 parent 0a16b56
commit c63356d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -29,7 +29,6 @@
         "keyword-spacing": "error",
         "new-cap": "error",
         "no-array-constructor": "error",
-        "no-console": "warn",
         "no-eval": "error",
         "no-fallthrough": "warn",
         "no-loop-func": "error",

diff --git a/js/ajax.js b/js/ajax.js
@@ -76,6 +76,7 @@ var AJAX = {
         var eventName = 'onload_' + AJAX.hash(file);
         $(document).on(eventName, func);
         if (this.debug) {
+            // eslint-disable-next-line no-console
             console.log(
                 // no need to translate
                 'Registered event ' + eventName + ' for file ' + file
@@ -97,6 +98,7 @@ var AJAX = {
         var eventName = 'teardown_' + AJAX.hash(file);
         $(document).on(eventName, func);
         if (this.debug) {
+            // eslint-disable-next-line no-console
             console.log(
                 // no need to translate
                 'Registered event ' + eventName + ' for file ' + file
@@ -116,6 +118,7 @@ var AJAX = {
         var eventName = 'onload_' + AJAX.hash(file);
         $(document).trigger(eventName);
         if (this.debug) {
+            // eslint-disable-next-line no-console
             console.log(
                 // no need to translate
                 'Fired event ' + eventName + ' for file ' + file
@@ -134,6 +137,7 @@ var AJAX = {
         var eventName = 'teardown_' + AJAX.hash(file);
         $(document).triggerHandler(eventName);
         if (this.debug) {
+            // eslint-disable-next-line no-console
             console.log(
                 // no need to translate
                 'Fired event ' + eventName + ' for file ' + file
@@ -310,6 +314,7 @@ var AJAX = {
         }
 
         if (AJAX.debug) {
+            // eslint-disable-next-line no-console
             console.log('Loading: ' + url); // no need to translate
         }
 
@@ -933,6 +938,7 @@ $(document).on('submit', 'form', AJAX.requestHandler);
  */
 $(document).ajaxError(function (event, request) {
     if (AJAX.debug) {
+        // eslint-disable-next-line no-console
         console.log('AJAX error: status=' + request.status + ', text=' + request.statusText);
     }
     // Don't handle aborted requests

diff --git a/js/console.js b/js/console.js
@@ -182,7 +182,9 @@ var Console = {
                     var data = JSON.parse(xhr.responseText);
                     Console.ajaxCallback(data);
                 } catch (e) {
+                    // eslint-disable-next-line no-console
                     console.trace();
+                    // eslint-disable-next-line no-console
                     console.log('Failed to parse JSON: ' + e.message);
                 }
             });

diff --git a/js/designer/database.js b/js/designer/database.js
@@ -140,6 +140,7 @@ var DesignerOfflineDB = (function () {
     };
 
     designerDB.onerror = function (e) {
+        // eslint-disable-next-line no-console
         console.log(e);
     };