Extract message type match from Generator::getMessage

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
phpmyadmin · May 16, 2024 · d17e46c · d17e46c
1 parent cf44e8b
commit d17e46c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/src/Html/Generator.php b/src/Html/Generator.php
@@ -399,7 +399,7 @@ public static function getStartAndNumberOfRowsFieldsetData(string $sqlQuery): ar
     public static function getMessage(
         Message|string $message,
         string|null $sqlQuery = null,
-        MessageType|string $type = MessageType::Notice,
+        MessageType $type = MessageType::Notice,
     ): string {
         $retval = '';
 
@@ -422,14 +422,6 @@ public static function getMessage(
         }
 
         if (is_string($message)) {
-            if (is_string($type)) {
-                $type = match ($type) {
-                    'success' => MessageType::Success,
-                    'error' => MessageType::Error,
-                    default => MessageType::Notice,
-                };
-            }
-
             $message = new Message($message, $type);
         }
 

diff --git a/src/Twig/MessageExtension.php b/src/Twig/MessageExtension.php
@@ -6,6 +6,7 @@
 
 use PhpMyAdmin\Html\Generator;
 use PhpMyAdmin\Message;
+use PhpMyAdmin\MessageType;
 use Twig\Extension\AbstractExtension;
 use Twig\TwigFilter;
 use Twig\TwigFunction;
@@ -41,6 +42,20 @@ public function getFilters(): array
     /** @inheritDoc */
     public function getFunctions(): array
     {
-        return [new TwigFunction('statement_message', Generator::getMessage(...), ['is_safe' => ['html']])];
+        return [
+            new TwigFunction(
+                'statement_message',
+                static function (string $message, string $statement, string $context): string {
+                    $type = match ($context) {
+                        'success' => MessageType::Success,
+                        'error', 'danger' => MessageType::Error,
+                        default => MessageType::Notice,
+                    };
+
+                    return Generator::getMessage($message, $statement, $type);
+                },
+                ['is_safe' => ['html']],
+            ),
+        ];
     }
 }