Skip to content

Commit

Permalink
bug #3577443 [edit] "Browse foreign values" does not show on ajax edit
Browse files Browse the repository at this point in the history
  • Loading branch information
madhuracj committed Oct 18, 2012
1 parent 4425709 commit e1afee9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Expand Up @@ -46,6 +46,7 @@ VerboseMultiSubmit, ReplaceHelpImg
+ [interface] Autoselect username input on cookie login page
- bug #3563799 [interface] Grid editing destroying huge amount of data
+ [import] Remove support for the unactive docSQL import format
- bug #3577443 [edit] "Browse foreign values" does not show on ajax edit

3.5.4.0 (not yet released)
- bug #3570212 [edit] uuid_short() is a no-arguments function
Expand Down
3 changes: 0 additions & 3 deletions js/tbl_change.js
Expand Up @@ -257,9 +257,6 @@ $(function() {
$null_checkbox.prop('checked', false);
});

// these were hidden via the "hide" class
$('a.foreign_values_anchor').show();

/**
* Handles all current checkboxes for Null; this only takes care of the
* checkboxes on currently displayed rows as the rows generated by
Expand Down
6 changes: 3 additions & 3 deletions libraries/insert_edit.lib.php
Expand Up @@ -755,7 +755,7 @@ function PMA_getForeignLink($column, $backup_field, $column_name_appendix,
. 'id="field_' . ($idindex) . '_3" '
. 'value="' . htmlspecialchars($data) . '" />';

$html_output .= '<a class="hide foreign_values_anchor" target="_blank" '
$html_output .= '<a class="foreign_values_anchor" target="_blank" '
. 'onclick="window.open(this.href,\'foreigners\', \'width=640,height=240,'
. 'scrollbars=yes,resizable=yes\'); return false;" '
. 'href="browse_foreigners.php?'
Expand Down Expand Up @@ -1833,7 +1833,7 @@ function PMA_setSessionForEditNext($one_where_clause)
/**
* set $goto_include variable for different cases and retrieve like,
* if $GLOBALS['goto'] empty, if $goto_include previously not defined
* and new_insert, same_insert, edit_next
* and new_insert, same_insert, edit_next
*
* @param string $goto_include store some script for include, otherwise it is
* boolean false
Expand Down Expand Up @@ -2081,7 +2081,7 @@ function PMA_getLinkForRelationalDisplayField($map, $relation_field,
}

/**
* Transform edited values
* Transform edited values
*
* @param string $db db name
* @param string $table table name
Expand Down

0 comments on commit e1afee9

Please sign in to comment.