Fix MissingParamType psalm check

Signed-off-by: William Desportes <williamdes@wdes.fr>
phpmyadmin · Apr 28, 2020 · e204cc0 · e204cc0
1 parent 70e9a29
commit e204cc0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 32 deletions.
diff --git a/libraries/classes/Table/ColumnsDefinition.php b/libraries/classes/Table/ColumnsDefinition.php
@@ -24,13 +24,26 @@
  */
 final class ColumnsDefinition
 {
+    /**
+     * @param Response          $response        Response object
+     * @param Template          $template        Template
+     * @param Transformations   $transformations Transformations
+     * @param Relation          $relation        Relation
+     * @param DatabaseInterface $dbi             Database Interface instance
+     * @param string            $action          Action
+     * @param int               $num_fields      The number of fields
+     * @param string|null       $regenerate      Use regeneration
+     * @param array|null        $selected        Selected
+     * @param array|null        $fields_meta     Fields meta
+     * @param array|null        $field_fulltext  Fields full text
+     */
     public static function displayForm(
         Response $response,
         Template $template,
         Transformations $transformations,
         Relation $relation,
         DatabaseInterface $dbi,
-        $action,
+        string $action,
         $num_fields = 0,
         $regenerate = null,
         $selected = null,

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -4315,36 +4315,6 @@ parameters:
 			count: 1
 			path: libraries/classes/Table.php
 
-		-
-			message: "#^Method PhpMyAdmin\\\\Table\\\\ColumnsDefinition\\:\\:displayForm\\(\\) has parameter \\$action with no typehint specified\\.$#"
-			count: 1
-			path: libraries/classes/Table/ColumnsDefinition.php
-
-		-
-			message: "#^Method PhpMyAdmin\\\\Table\\\\ColumnsDefinition\\:\\:displayForm\\(\\) has parameter \\$field_fulltext with no typehint specified\\.$#"
-			count: 1
-			path: libraries/classes/Table/ColumnsDefinition.php
-
-		-
-			message: "#^Method PhpMyAdmin\\\\Table\\\\ColumnsDefinition\\:\\:displayForm\\(\\) has parameter \\$fields_meta with no typehint specified\\.$#"
-			count: 1
-			path: libraries/classes/Table/ColumnsDefinition.php
-
-		-
-			message: "#^Method PhpMyAdmin\\\\Table\\\\ColumnsDefinition\\:\\:displayForm\\(\\) has parameter \\$num_fields with no typehint specified\\.$#"
-			count: 1
-			path: libraries/classes/Table/ColumnsDefinition.php
-
-		-
-			message: "#^Method PhpMyAdmin\\\\Table\\\\ColumnsDefinition\\:\\:displayForm\\(\\) has parameter \\$regenerate with no typehint specified\\.$#"
-			count: 1
-			path: libraries/classes/Table/ColumnsDefinition.php
-
-		-
-			message: "#^Method PhpMyAdmin\\\\Table\\\\ColumnsDefinition\\:\\:displayForm\\(\\) has parameter \\$selected with no typehint specified\\.$#"
-			count: 1
-			path: libraries/classes/Table/ColumnsDefinition.php
-
 		-
 			message: "#^Cannot access offset mixed on array\\|bool\\.$#"
 			count: 1

diff --git a/psalm.xml b/psalm.xml
@@ -29,7 +29,6 @@
         <PropertyNotSetInConstructor errorLevel="info" />
         <MissingConstructor errorLevel="info" />
         <MissingClosureParamType errorLevel="info" />
-        <MissingParamType errorLevel="info" />
 
         <RedundantCondition errorLevel="info" />