Skip to content

Commit

Permalink
Whitelist relative URLs from built in transformatons
Browse files Browse the repository at this point in the history
Fixes #12483

Signed-off-by: Michal Čihař <michal@cihar.com>
  • Loading branch information
nijel committed Aug 24, 2016
1 parent 38cf234 commit ed6188d
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ phpMyAdmin - ChangeLog
- issue #12374 Reintroduced simplified PmaAbsoluteUri configuration directive
- issue Always use UTC time in HTTP headers
- issue #12479 Simplified validation of external links
- issue #12483 Fix browsing tables with built in transformations

4.6.4 (2016-08-16)
- issue [security] Weaknesses with cookie encryption, see PMASA-2016-29
Expand Down
20 changes: 20 additions & 0 deletions libraries/sanitizing.lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ function PMA_checkLink($url, $http=false, $other=false)
'https://',
'./url.php?url=https%3a%2f%2f',
'./doc/html/',
# possible return values from Util::getScriptNameForOption
'./index.php?',
'./server_databases.php?',
'./server_status.php?',
'./server_variables.php?',
'./server_privileges.php?',
'./db_structure.php?',
'./db_sql.php?',
'./db_search.php?',
'./db_operations.php?',
'./tbl_structure.php?',
'./tbl_sql.php?',
'./tbl_select.php?',
'./tbl_change.php?',
'./sql.php?',
# Hardcoded options in libraries/special_schema_links.lib.php
'./db_events.php?',
'./db_routines.php?',
'./server_privileges.php?',
'./tbl_structure.php?',
);
if ($other) {
$valid_starts[] = 'mailto:';
Expand Down

0 comments on commit ed6188d

Please sign in to comment.