Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV import to new table broken #11850

Closed
ibennetch opened this issue Jan 13, 2016 · 0 comments
Closed

CSV import to new table broken #11850

ibennetch opened this issue Jan 13, 2016 · 0 comments
Assignees
@nijel
Labels
Bug A problem or regression with an existing feature
Milestone
4.6.0

Comments

@ibennetch
Copy link
Member

Testing with the current master (last commit b554a72).

Importing a CSV file and expecting phpMyAdmin to create the table fails. Go to the main page Import tab or a database Import tab and select a CSV file for import. First, the message states success

Import has been successfully finished, 3 queries executed.

Then further down the page, failure:

1146 - Table 'CSV_DB.TBL_NAME' doesn't exist

I do not see the database or table in the listing.

Git tells me 9187445 is the first bad commit.
lem9 referenced this issue Jan 13, 2016
@nijel
Display results for all queries returning data
9187445 
This is limited to 50 queries, and removes detection based on query
string. It rather passes all (up to 50) queries to sql.php, which can
properly handle any query returing results.

Fixes #11741

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel nijel self-assigned this Jan 13, 2016
@nijel nijel added this to the 4.6.0 milestone Jan 13, 2016
@nijel nijel added the Bug A problem or regression with an existing feature label Jan 14, 2016
nijel added a commit that referenced this issue Feb 17, 2016
@nijel
Remove sql data parameter
84c12c2 
This just makes the SQL import different from others leading to subtle
breakages.

Issue #11850

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Feb 17, 2016
@nijel
Always use local static storage of executed queries
ee8f9b0 
Issue #11850

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel nijel closed this as completed in 18f9231 Feb 17, 2016
nijel added a commit that referenced this issue Feb 17, 2016
@nijel
Correct fix for table import processing
dd09116 
We need to consistently propagate the $sql_data array.

Issue #11850

Signed-off-by: Michal Čihař <michal@cihar.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nijel nijel

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
2 participants
@nijel @ibennetch