Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export creates invalid SQL with comments #12178

Closed
DjLeChuck opened this issue Apr 12, 2016 · 3 comments
Closed

Export creates invalid SQL with comments #12178

DjLeChuck opened this issue Apr 12, 2016 · 3 comments
Assignees
Labels
question Used when we need feedback from the submitter or when the issue is a question about PMA

Comments

@DjLeChuck
Copy link

About the issue #12076 the problem still exists.

I see the fix phpmyadmin/sql-parser@ad0e75f with a git log but the problem is always present.

Steps to reproduce

  1. Create a field DEFAULT NULL with a comment
  2. Export table

Expected behaviour

`image` varchar(200) DEFAULT NULL COMMENT 'upload_image',

Actual behaviour

`image` varchar(200) DEFAULT NULL COMMENT AS `upload_image`,

Server configuration

phpMyAdmin version: 4.7.0-dev

@nijel
Copy link
Contributor

nijel commented Apr 12, 2016

What version of SQL parser do you have installed?

@nijel nijel added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Apr 12, 2016
@DjLeChuck
Copy link
Author

I have just cloning this repository nothing else so I don't know. How can I
see that?

Le mardi 12 avril 2016, Michal Čihař notifications@github.com a écrit :

What version of SQL parser do you have installed?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12178 (comment)

DjLeChuck
http://www.djlechuck.fr

@DjLeChuck
Copy link
Author

In composer.json: "phpmyadmin/sql-parser": "~3.3"

EDIT:
So I was in 3.4.0 and update to 3.4.2 via composer update, problem diseappear.

@nijel nijel self-assigned this Apr 12, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Used when we need feedback from the submitter or when the issue is a question about PMA
Projects
None yet
Development

No branches or pull requests

2 participants