Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure since update to SQL parser 3.4.9 #12612

Closed
nijel opened this issue Oct 3, 2016 · 3 comments
Closed

Test failure since update to SQL parser 3.4.9 #12612

nijel opened this issue Oct 3, 2016 · 3 comments
Assignees
@devenbansod
Labels
Bug A problem or regression with an existing feature
Milestone
4.6.5

Comments

@nijel
Copy link
Contributor

nijel commented Oct 3, 2016

The latest SQL parser release broke something:

     [exec] 1) PMA_Import_Test::testPMAGetMatchedRows
     [exec] Undefined index: WHERE
     [exec] 
     [exec] /home/travis/build/phpmyadmin/phpmyadmin/libraries/sql-parser/src/Utils/Query.php:569
     [exec] /home/travis/build/phpmyadmin/phpmyadmin/libraries/import.lib.php:1537
     [exec] /home/travis/build/phpmyadmin/phpmyadmin/libraries/import.lib.php:1443
     [exec] /home/travis/build/phpmyadmin/phpmyadmin/test/libraries/PMA_import_test.php:395
     [exec] /home/travis/build/phpmyadmin/phpmyadmin/test/libraries/PMA_import_test.php:375
@nijel nijel added the Bug A problem or regression with an existing feature label Oct 3, 2016
@devenbansod devenbansod self-assigned this Oct 3, 2016
@devenbansod devenbansod added this to the 4.6.5 milestone Oct 3, 2016
@devenbansod
Copy link
Member

Do you think this would require a new release or just a new tag would be okay ?

nijel added a commit to phpmyadmin/sql-parser that referenced this issue Oct 3, 2016
@nijel
Add changelog for phpmyadmin/phpmyadmin#12612
5c09051 
Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Oct 3, 2016
@nijel
Update SQL parser to 3.4.10
4e020de 
Fixes #12612

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel
Copy link
Contributor Author

nijel commented Oct 3, 2016

Creating tag is enough to make new release. I've just done that (3.4.10).

@nijel
Copy link
Contributor Author

nijel commented Oct 3, 2016

Thanks for fixing this quickly.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devenbansod devenbansod

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
4.6.5
Development

No branches or pull requests
2 participants
@nijel @devenbansod