Using CreateElement for adding HTML #12907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyasSinha
force-pushed
the
refactorcreateelement
branch
from
5726940
to
756c655
Compare
Current coverage is 54.18% (diff: 100%)@@ master #12907 diff @@
==========================================
Files 466 466
Lines 69619 69619
Methods 2126 2126
Messages 0 0
Branches 0 0
==========================================
Hits 37724 37724
Misses 31895 31895
Partials 0 0
|
Signed-off-by: Shreyas Sinha <shreyas.sinha14@gmail.com>
nijel
suggested changes
Jan 20, 2017
| var version_information_message_link = document.createElement('a'); | ||
| version_information_message_link.href = url; | ||
| version_information_message_link.class = 'disableAjax'; | ||
| version_information_message_link.innerHTML = escapeHtml(data.version); |
There was a problem hiding this comment.
I think it would be better to use text here to avoid need for escapeHtml....
| } | ||
| var $liPmaVersion = $('#li_pma_version'); | ||
| $liPmaVersion.find('span.latest').remove(); | ||
| $liPmaVersion.append(version_information_message); | ||
| document.getElementById("li_pma_version").appendChild(version_information_message); |
There was a problem hiding this comment.
Why getting element again, while we already have it as $liPmaVersion?
ShreyasSinha
force-pushed
the
refactorcreateelement
branch
from
ad0e0aa
to
3c2c392
Compare
Signed-off-by: Shreyas Sinha <shreyas.sinha14@gmail.com>
nijel
approved these changes
Jan 20, 2017
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12764
Before submitting pull request, please check that every commit: