Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showing tooltip for user not in user table #13305

Closed
wants to merge 1 commit into from

Conversation

manishbisht
Copy link
Contributor

@manishbisht manishbisht commented May 27, 2017

Fixes #12718

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Signed-off-by: Manish Bisht <manish.bisht490@gmail.com>
@codecov
Copy link

codecov bot commented May 27, 2017

Codecov Report

Merging #13305 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13305      +/-   ##
==========================================
+ Coverage   54.53%   54.53%   +<.01%     
==========================================
  Files         466      466              
  Lines       70385    70388       +3     
==========================================
+ Hits        38382    38386       +4     
+ Misses      32003    32002       -1

@nijel
Copy link
Contributor

nijel commented Jun 6, 2017

Thanks I've merged your change with minor edits (coding style and reusing message we use elsewhere for this) as 253c9be.

@nijel nijel closed this Jun 6, 2017
@nijel nijel self-assigned this Jun 6, 2017
@nijel nijel added this to the 4.7.2 milestone Jun 6, 2017
@manishbisht manishbisht deleted the password-fix branch June 6, 2017 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password No shown for user not in user table
2 participants