Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank text nodes from edit/copy/delete table cells in table rows #13421

Closed
btacordex opened this issue Jun 29, 2017 · 1 comment
Closed
Assignees
Labels
Bug A problem or regression with an existing feature
Milestone

Comments

@btacordex
Copy link
Contributor

In any query in which the results come from a single table, the rows in the result table are about twice as tall as necessary. This is because the table cells containing the edit, copy, and delete links also contain a text node on either side containing a space for no discernible reason. They also lack the nowrap class, so the spaces wrap and you end up with a cell three text lines high instead of one.

If additional vertical space is desired, the cells could be given a larger line-height or height, but three lines is too much and wastes a lot of screen space.

Steps to reproduce

  1. Perform any single-table query, e.g. (SELECT * FROM myTable)

Expected behaviour

The rows should be one line tall.

Actual behaviour

They're three lines tall.

Server configuration

Operating system:
OS X 10.12.5

Web server:
Apache

Database:
MySQL 5.7.18

PHP version:
5.6.30

phpMyAdmin version:
4.7.2

Client configuration

Browser:
Safari or Chrome

Operating system:
OS X 10.12.5

@nijel nijel self-assigned this Nov 27, 2017
@nijel nijel added the Bug A problem or regression with an existing feature label Nov 27, 2017
@nijel nijel added this to the 4.7.3 milestone Nov 27, 2017
@nijel
Copy link
Contributor

nijel commented Nov 27, 2017

Duplicate of #13445

@nijel nijel marked this as a duplicate of #13445 Nov 27, 2017
@nijel nijel closed this as completed Nov 27, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants