Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring designer #15163

Open
Bournvita1998 opened this issue Apr 8, 2019 · 7 comments
Open

Refactoring designer #15163

Bournvita1998 opened this issue Apr 8, 2019 · 7 comments
Labels
enhancement A feature request for improving phpMyAdmin refactoring
Projects
Enhancements

Comments

@Bournvita1998
Copy link
Contributor

[Designer's JS code related]

I have observed a few performance issues in the designer's JS code like calculating multiples things inside a for loop (which could be calculated outside the loop). Also other than the performance issues, I also observed some bad coding practices in this section, like declaring each variable in a different line(bad coding practice).
@Bournvita1998
Copy link
Contributor Author

Working on it. Will create a PR soon

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin refactoring labels Apr 8, 2019
@Bournvita1998 Bournvita1998 mentioned this issue Apr 8, 2019
Closed
6 tasks
@Bournvita1998
Copy link
Contributor Author

@williamdes Please review this PR, will work on other files once you approve these changes

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 8, 2019
@Bournvita1998
Copy link
Contributor Author

@williamdes any reviews?

Bournvita1998 added a commit to Bournvita1998/phpmyadmin that referenced this issue Apr 13, 2019
@Bournvita1998
fiexs phpmyadmin#15163
3bb8976 
Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>

Improved the performance of all the JS files of the designer and imrpoved the names of the new variables used.
@Bournvita1998 Bournvita1998 changed the title Improving performance of the designer Refactoring designer May 28, 2019
@Bournvita1998
Copy link
Contributor Author

@williamdes @ibennetch I am planning to create a single PR for the whole refactoring work in the designer section. Good to go?

@MauricioFauth
Copy link
Member

@Bournvita1998 I don't think it is a good idea, it is very difficult to review such big pull request. It is better to open small pull requests that can be merged into master branch or into a new branch just for this.

@Bournvita1998
Copy link
Contributor Author

@MauricioFauth Would you like to suggest how can that be done?
Can we divide this into different PRs like one for each js file in the designer?

@MauricioFauth
Copy link
Member

MauricioFauth commented May 29, 2019 •
edited

@Bournvita1998 I created the gsoc-db-designer branch for now, so you can open pull requests against that branch.

cc @ibennetch

@Bournvita1998 Bournvita1998 mentioned this issue Jun 3, 2019
Merged
6 tasks
@williamdes williamdes added this to Triage zone in Enhancements Jan 23, 2020
@williamdes williamdes moved this from Triage zone to Deprecations in Enhancements Jan 23, 2020
@williamdes williamdes moved this from Deprecations to Code base in Enhancements Jan 23, 2020
@williamdes williamdes removed the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature request for improving phpMyAdmin refactoring
Projects
Enhancements
  
Code base
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MauricioFauth @williamdes @Bournvita1998