Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of the pages in the designer could be saved with a already existing name #15432

Closed
Bournvita1998 opened this issue Aug 14, 2019 · 5 comments
Closed
Assignees
Projects
Milestone

Comments

@Bournvita1998
Copy link
Contributor

@Bournvita1998 Bournvita1998 commented Aug 14, 2019

Describe the bug

Pages in the designer can be saved with the exiting names.

To Reproduce

Steps to reproduce the behaviour:

  1. Go to designer
  2. Click on 'Save page' in the left panel
  3. Try to save a page with some name. (let's say qwe here)
  4. Save multiple pages using the same name(qwe here).

Expected behaviour

It should throw and error saying "there already exists a page named 'qwe', please rename it to something else".

Screenshots

Complete screen:

Selection_073

When clicked on the 'select page' drop down:

Menu_070

@williamdes williamdes added this to Needs triage in issues via automation Aug 14, 2019
@williamdes williamdes added the ui label Aug 14, 2019
@williamdes williamdes moved this from Needs triage to Reproduced in issues Aug 15, 2019
@tabraiz961
Copy link
Contributor

@tabraiz961 tabraiz961 commented Jan 6, 2020

I am new to contributions. Can you help me out with steps required to correctly solve the issue.

Loading

@williamdes
Copy link
Member

@williamdes williamdes commented Jan 6, 2020

@tabraiz961 I suggest that you find another issue on this repository because the designer is not the best part of our code-base for someone new :)

Loading

@tabraiz961
Copy link
Contributor

@tabraiz961 tabraiz961 commented Jan 6, 2020

@williamdes glad to know that.

Loading

@tabraiz961
Copy link
Contributor

@tabraiz961 tabraiz961 commented Jan 9, 2020

@tabraiz961 I suggest that you find another issue on this repository because the designer is not the best part of our code-base for someone new :)

Hi @williamdes i looked in some issues but this seemed to be appropriate for me so i submmited a commit with a sign off on master. Please look into it and if it seems okay to merge.
Also i tried with the fork but it seemed to have css broken and that branch was also some commits behind the master so i downloaded and worked on the most recent zip. Can you tell me if its the correct way ?

Loading

@williamdes
Copy link
Member

@williamdes williamdes commented Jan 9, 2020

Can you tell me if its the correct way ?

I would say it is a way to contribute but not the easiest way :)
To fix the CSS issue you need to run the yarn command and yarn run css-compile

Please create a branch from QA_5_0 before you do the fix and then you can commit and push your changes. You will then be able to open a pull-request here to branch QA_5_0

If you already opened a pull-request please comment the #id here

Loading

@williamdes williamdes self-assigned this Jan 12, 2020
@williamdes williamdes added this to the 5.0.2 milestone Jan 12, 2020
williamdes added a commit that referenced this issue Jan 12, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Jan 14, 2020
williamdes added a commit that referenced this issue Jan 15, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
issues
  
Closed
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants