Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page number is not being updated in the URL after saving a designer's page #15440

Closed
Bournvita1998 opened this issue Aug 18, 2019 · 2 comments

Comments

@Bournvita1998
Copy link
Contributor

commented Aug 18, 2019

Describe the bug

When we save a new page, it's expected to update the url accordingly.

To Reproduce

Steps to reproduce the behavior:

  1. Go and save a page in the designer.
  2. Observe the url.
  3. Make a small change (may move one of the tables a bit).
  4. Save the page again with a different name.
  5. Observe the change in the url before and after adding a new page. (URL is still referring to the page stored earlier but not the recently added one, although the name of the page and data displayed refers to the currently stored page)

Start:
Selection_081

Saving a new page:
Selection_082

After clicking the "GO" button(observe the change in the URL, page's name):
Selection_083

Expected behavior

It's expected that the URL of the page should be the same as the data stored in the page.

Right now(on clicking the GO button):
Selection_084

Expected(on clicking the GO button):
Selection_085

@williamdes williamdes added this to Needs triage in issues via automation Aug 29, 2019

@asprazz

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2019

Hi! @williamdes , I would like to work on this. I found a solution where it can be solved by just re-loading the selectedPage after creating a new one or if there is a way to update url without reloading which is more desired way Please guide me through it.

@williamdes

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

@asprazz you can create a pull-request from and to branch QA_4_9, do not forget to sign-off
using --signoff option to add your signoff line in the commit body, please use your real name (this option is an agreement to our policy)

I will review ASAP and merge if the fix is okay and works fine :)

@asprazz asprazz referenced this issue Sep 8, 2019
5 of 6 tasks complete

@williamdes williamdes added this to In Progress in Designer Sep 8, 2019

williamdes added a commit that referenced this issue Sep 8, 2019
Fix #15440 - Page number is not being updated in the URL after saving…
… a designer's page

Fixes: #15440
Pull-request: #15464
Signed-off-by: William Desportes <williamdes@wdes.fr>

@williamdes williamdes self-assigned this Sep 8, 2019

@williamdes williamdes added this to the 4.9.1 milestone Sep 8, 2019

@williamdes williamdes added the has-pr label Sep 8, 2019

@williamdes williamdes moved this from In Progress to Done in Designer Sep 8, 2019

williamdes added a commit that referenced this issue Sep 8, 2019
Add ChangeLog entries for #15349, #15440, 58f5611, 79c1b62, baada95, 6…
…31de23

Signed-off-by: William Desportes <williamdes@wdes.fr>

@williamdes williamdes closed this in 3b9eb2b Sep 8, 2019

issues automation moved this from Needs triage to Closed Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.