Table grouping doesn't work

[ibennetch]

Using 4.9.4 or master, the table level grouping feature doesn't work.

To reproduce, you need a database with several tables, the default separator is __ (two underscores), such as table__1, table__2, table__3.

Expected behavior:

Actual behavior:

Git bisect tells me 24f1cb2 is the first bad commit

Author: Madhura Jayaratne <madhura.cj@gmail.com>
Date:   Fri Jun 5 09:54:31 2015 +0530

    rfe #1634 Don't group tables in tree if the result has only one group

    Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>

In that case, 4.5.0 would be the first affected version.

[williamdes]

@ibennetch is that a duplicate of #12817 ?

[ibennetch]

I think it's not a duplicate of the reported issue, because that's about database grouping when no other databases are shown, and this relates to the table level. It does seem to be the same as the comment at #12817 (comment), though.

[thesmallstar]

@ibennetch Can I work on this?

[williamdes]

@thesmallstar Yes, you can work on this issue

[thesmallstar]

Should I work on master Branch?

[thesmallstar]

@ibennetch This is rather a feature, though not needed. it was added so that no grouping is done if there is only one group, that might make sense in some cases.
Have a look at this,

When I add one more table that does not belong to this group or increase the number of groups.

Check line 761 in NavigationTree.php
Removing this would solve the issue.

// rfe #1634 Don't group if there's only one group and no other items
        if (count($prefixes) === 1) {
            $keys = array_keys($prefixes);
            $key = $keys[0];
            if ($prefixes[$key] == count($node->children) - 1) {
                unset($prefixes[$key]);
            }
        }
```

[thesmallstar]

@williamdes I am considering this a bug then not a feature, Which branch should I work on?

[williamdes]

@thesmallstar please use QA_5_0

[williamdes]

https://sourceforge.net/p/phpmyadmin/feature-requests/1634/

24f1cb2 (in 4.5.0.0)

http://phpmyadmin150.rssing.com/chan-30024075/all_p8.html

[...]
On the new features front, rfe #1634 was discussed during the last IRC meeting and received the green light to be implemented. This rfe requested not to group items in the navigation panel when there is only a single group and no other items or groups in a particular sub tree.

[...]

Feature requests implemented
#1634 Don't group tables in tree if the result has only one group
[...]

@ibennetch this is the history I found

So, bug or feature ?

[williamdes]

https://github.com/phpmyadmin/phpmyadmin/wiki/2015-05_Meeting_IRC_Log

[williamdes]

"09:27 < Marc9> Not grouping here would be inconsistent and we would get a RFE to bring it back"

Years later here we are.

cc @lem9

[williamdes]

cc @OlafvdSpek

[OlafvdSpek]

Haha, isn't it ironic @ibennetch was in that IRC meeting too? ;) FYI I wasn't.
Is grouping really not working or is it working as intended (i.e. don't group when there's only one group)?

[ibennetch]

Wow, that’s so funny that we had this very talk that long ago. Perhaps not as funny that I didn’t remember it. I’m torn. This seems like what the users would want, but it’s not super intuitive. I think we should better document this (in the documentation and maybe even as a tool tip in the navigation pane) then leave it how it is.

[thesmallstar]

@OlafvdSpek it is working as intended i.e don't group when there's only one group

[williamdes]

@OlafvdSpek since you did the feature request, do you want to remove the feature ?

IMO I would not remove it since not grouping looks nicer but on another hand having a group is what I would expect so I would remove it.

So "I’m torn" too

[OlafvdSpek]

No, of course I don't want to remove it. ;)
Having only one group just doesn't make sense..

[thesmallstar]

@williamdes @OlafvdSpek as @ibennetch said, if we do not remove it should we document it or show a tool tip?

[williamdes]

3rd option for me: add a configuration override

I agree for the documentation, maybe in FAQ?

[OlafvdSpek]

IMO it's low priority, I'd focus on other issues.

[IlyasMohetna]

Please follow these steps to resolve your problem :

1 - Locate the file config.inc.php for phpmyadmin configuration
2 - Search for $cfg['Servers'][$i]['table_coords']
3 - Under the line you found put this line of code: $cfg['Servers'][$i]['table_group'] = 'group_';

Let me know if it worked!