Feature: Save width of columns #14507

diyoyo · 2018-07-21T20:35:17Z

Steps to reproduce

Select a table to browse
Adjust one of the column's width
Come back on that very same page later

Expected behaviour

The width of the column should be set to the same as the latest modification

Actual behaviour

The width is back to default behavior.

Server configuration

Operating system:

Web server:

Database:

PHP version:

phpMyAdmin version:
4.8.2

Client configuration

Browser:
Firefox, Chrome
Operating system:

lem9 · 2018-07-23T13:03:46Z

Not a bug because the width is not supposed to be saved. Could be a feature request but this is open to discussion about what would be the best behavior.

bozhi91 · 2019-05-12T22:01:09Z

Hey guys. Can I implement this feature?

bozhi91 · 2019-05-14T20:39:28Z

williamdes, Can you assign me and my team to this feature. We are interested in implement it.
We need this for a school project.

williamdes · 2019-05-14T20:49:55Z

@bozhi91 I can not assign you or your team since you are not phpmyadmin members but you are now "assigned" on this enhancement

Please keep us updated if you are not interested anymore or are actively working on this issue :)

bozhi91 · 2019-05-14T21:10:18Z

Hi William, Thanks for your reply. My idea is to implement this improvement and then push the changes and hope the one that's in charge will approve it. Since I'm assigned on the enhancement, does that mean that we can start with the implementation of the feature now? Regards,

williamdes · 2019-05-14T21:23:19Z

You can start the implementation, be sure to use latest master branch as base for your work and to target master when creating the pull-request Please use the - -sign-off option of git when creating commits I will review the pull-request and decide if more work needs to be done or if I can merge your enhancement Other team members will maybe review the pull-request

bozhi91 · 2019-05-14T21:27:14Z

Many thanks. I'll will inform you and the other guys about the progress. Also we'll probably need your help at some point. I guess we can count on you, right? Regards.

…

On Tue, May 14, 2019 at 11:23 PM William Desportes ***@***.***> wrote: You can start the implementation, be sure to use latest master branch as base for your work and to target master when creating the pull-request Please use the - -sign-off option of git when creating commits I will review the pull-request and decide if more work needs to be done or if I can merge your enhancement Other team members will maybe review the pull-request — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14507?email_source=notifications&email_token=AF6TPGNSVEQ4F4TCLBX3M7TPVMUVJA5CNFSM4FLHATDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVM2QOQ#issuecomment-492415034>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF6TPGJO4PNKJY5DECKXXJLPVMUVJANCNFSM4FLHATDA> .

williamdes · 2019-05-14T21:57:53Z

Yes, I will help you if you need :)

bozhi91 · 2019-06-10T22:44:15Z

Hi William,
I want to comment you something about the project.
We started the development and we decided to store the table's width in cookies instead of using another tables for saving all the data. This way could be more comfortable for the users because only the users using the same computer may see the changes. If someone connects remotely, will not see the changes because does not have the data stored in cookies.
Also will be more easy to implement this functionality because we will apply a minor changes in the code.
Hope this will not be a problem.

Regards,

williamdes · 2019-06-11T05:44:18Z

Seems okay 👍
What do you think about that @ibennetch?

bozhi91 · 2019-06-25T18:51:36Z

Hi William,
We have finished with our implementation. Now we need to do the pull request.
However, we were working on the forked project so how do I do the pull request?
Do I have to do it inside the forked project or what?
Thanks

williamdes · 2019-06-25T19:07:40Z

Now we need to do the pull request.

Yes, please and add #14507 into the PR message

Open the PR from the fork to the phpMyAdmin repo.

bozhi91 · 2019-06-25T22:11:25Z

What do you mean by: "add #14507 into the PR message"?
I have to comment that we have been working on this issue in the pull request message?

williamdes · 2019-06-26T06:18:54Z

@bozhi91

We fixed the issue number: #14507

Nothing more is needed :)

bozhi91 · 2019-06-26T07:12:23Z

Hi,
The pull request is done. I think you can see it.
We are waiting for your answer.
Thanks for your help.

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Signed-off-by: Saksham Gupta <shucon01@gmail.com> Add functions and documentation Signed-off-by: Saksham Gupta <shucon01@gmail.com> Use db_table key as hash Signed-off-by: Saksham Gupta <shucon01@gmail.com>

Signed-off-by: Saksham Gupta <shucon01@gmail.com> Add functions and documentation Signed-off-by: Saksham Gupta <shucon01@gmail.com> Use db_table key as hash Signed-off-by: Saksham Gupta <shucon01@gmail.com> Fix code quality Signed-off-by: Saksham Gupta <shucon01@gmail.com>

yurenchen000 · 2021-12-19T12:57:47Z

Hi, The pull request is done. I think you can see it. We are waiting for your answer. Thanks for your help.

seems master not have this feature.
I have use your diff in my deploy, and this make life easier.
// seems some time not store col width right: I resize colA localStore save colB or not store.
( I'm not sure is it related to hide OR re-orderd col. currenttly I edit localStore manually )

// the existing feature column sort & drag also help a lot !

👍 👍

Signed-off-by: KartikWatts <arorakartik4@gmail.com>

williamdes added the enhancement A feature request for improving phpMyAdmin label Nov 13, 2018

williamdes changed the title ~~Bug report: Width of columns are never saved~~ Feature: Save width of columns Nov 13, 2018

williamdes added the ui Issues relating to the user interface label Nov 13, 2018

bozhi91 mentioned this issue Jun 25, 2019

#14507 - Save width of columns #15360

Closed

shucon added a commit to shucon/phpmyadmin that referenced this issue Mar 16, 2021

Enhancement phpmyadmin#14507 Save width of columns

c70d556

Signed-off-by: Saksham Gupta <shucon01@gmail.com>

shucon linked a pull request Mar 16, 2021 that will close this issue

Enhancement #14507 Save width of columns #16739

Draft

6 tasks

williamdes added this to the 5.2.0 milestone Dec 19, 2021

williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Dec 19, 2021

KartikWatts added a commit to KartikWatts/phpmyadmin that referenced this issue Mar 26, 2022

Enhancement phpmyadmin#14507 Jump to table using keyboard

25a2f36

Signed-off-by: KartikWatts <arorakartik4@gmail.com>

ibennetch removed this from the 5.2.0 milestone May 11, 2022

ibennetch added this to the 5.2.1 milestone May 11, 2022

williamdes added the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022

williamdes removed this from the 5.2.1 milestone Oct 25, 2022

williamdes added affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) and removed affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) labels Oct 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Save width of columns #14507

Feature: Save width of columns #14507

diyoyo commented Jul 21, 2018

lem9 commented Jul 23, 2018

bozhi91 commented May 12, 2019

bozhi91 commented May 14, 2019

williamdes commented May 14, 2019

bozhi91 commented May 14, 2019 via email •

edited by williamdes

Loading

williamdes commented May 14, 2019 via email

bozhi91 commented May 14, 2019 via email

williamdes commented May 14, 2019 via email

bozhi91 commented Jun 10, 2019

williamdes commented Jun 11, 2019

bozhi91 commented Jun 25, 2019

williamdes commented Jun 25, 2019

bozhi91 commented Jun 25, 2019

williamdes commented Jun 26, 2019

bozhi91 commented Jun 26, 2019

yurenchen000 commented Dec 19, 2021 •

edited

Loading

Feature: Save width of columns #14507

Feature: Save width of columns #14507

Comments

diyoyo commented Jul 21, 2018

Steps to reproduce

Expected behaviour

Actual behaviour

Server configuration

Client configuration

lem9 commented Jul 23, 2018

bozhi91 commented May 12, 2019

bozhi91 commented May 14, 2019

williamdes commented May 14, 2019

bozhi91 commented May 14, 2019 via email • edited by williamdes Loading

williamdes commented May 14, 2019 via email

bozhi91 commented May 14, 2019 via email

williamdes commented May 14, 2019 via email

bozhi91 commented Jun 10, 2019

williamdes commented Jun 11, 2019

bozhi91 commented Jun 25, 2019

williamdes commented Jun 25, 2019

bozhi91 commented Jun 25, 2019

williamdes commented Jun 26, 2019

bozhi91 commented Jun 26, 2019

yurenchen000 commented Dec 19, 2021 • edited Loading

bozhi91 commented May 14, 2019 via email •

edited by williamdes

Loading

yurenchen000 commented Dec 19, 2021 •

edited

Loading