Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create view modal doesn't show #17390

Closed
liviuconcioiu opened this issue Feb 15, 2022 · 6 comments
Closed

Create view modal doesn't show #17390

liviuconcioiu opened this issue Feb 15, 2022 · 6 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone
5.2.1

Comments

@liviuconcioiu
Copy link
Contributor

liviuconcioiu commented Feb 15, 2022 •
edited by williamdes
Loading

Describe the bug

Create view modal doesn't show.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://demo.phpmyadmin.net/master-config/index.php?route=/sql&db=sakila&table=actor&pos=0
  2. Click on Create view
  3. No modal is shown

Expected behavior

The create view modal should show up.

Screenshots

16.02.2022_00.56.58_REC.mp4

Server configuration

  • phpMyAdmin version: 5.x
@williamdes
Copy link
Member

Confirmed

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface good first issue labels May 28, 2022
@williamdes williamdes added this to the 5.2.1 milestone May 28, 2022
@sooslaca
Copy link

same, subscribing for updates

@williamdes williamdes added the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022
@williamdes williamdes removed this from the 5.2.1 milestone Oct 25, 2022
@williamdes williamdes added the confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set label Oct 26, 2022
@williamdes williamdes added this to the 5.2.1 milestone Oct 26, 2022
@williamdes
Copy link
Member

5.3 is fixed, but 5.2 is not

@williamdes
Copy link
Member

Probably due to #17128

@williamdes
Copy link
Member

Also affects empty results as it is a different button technically

williamdes added a commit that referenced this issue Oct 26, 2022
@williamdes
Add a ChangeLog entry for #17390
be57ae7 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Oct 26, 2022
@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete and removed affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set labels Oct 26, 2022
@williamdes
Copy link
Member

Fixed by 51bf404
You can try it using the latest 5.2 version in development (phpMyAdmin 5.2+snapshot)

@williamdes williamdes mentioned this issue Dec 2, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Milestone
5.2.1
Development

No branches or pull requests
3 participants
@williamdes @liviuconcioiu @sooslaca