"Delete" button not asking for confirmation - deleting a row

[nunoperalta]

5.2.0

In some situations, clicking the "delete" button is deleting the row without any confirmation!!

I'm still trying to understand what's the pattern. Sometimes it asks, sometimes it deletes straight away.

[williamdes]

Hi @nunoperalta
Did you have such issues with 5.1.x ?

[nunoperalta]

Hi @nunoperalta Did you have such issues with 5.1.x ?

I don't remember ever having this issue, but it's very rare for me to be deleting rows using that button though.

[nunoperalta]

This just happened again. All I did was open a table from the sidebar, and then using the default sort (PK descending, per my settings), I clicked the very first "x" button (which is the latest inserted row). No confirmation - the delete ran straight away. No JavaScript errors reported in DevTools.

[williamdes]

I managed to reproduce this !
Hit F5 to refresh the page and as soon as possible click on the delete button

[williamdes]

I am marking this as skipped to this milestone, it may require risky changes

[nunoperalta]

Thanks @williamdes - I still from time to time don't get the confirmation alert, and I'm pretty sure it's not a "timing issue" (like opening the page and delete quickly), but I'm glad you found a way to reproduce this anyway!

[williamdes]

This one probably links to #16954

[nunoperalta]

Cheers. I don't think I am seeing any warning showing, when this happens to me. Could have been a coincidence, when it happened to that user. Or just another reason for this bug to happen :)

[williamdes]

Cheers. I don't think I am seeing any warning showing, when this happens to me. Could have been a coincidence, when it happened to that user. Or just another reason for this bug to happen :)

I think this could be another reason. Since the code needs to register itself to prevent the bug to occur. Anything that prevents it to register let's the bug occur