Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on update CURRENT_TIMESTAMP doesn't show as default on attributes select #18276

Closed
liviuconcioiu opened this issue Mar 19, 2023 · 3 comments
Closed

on update CURRENT_TIMESTAMP doesn't show as default on attributes select #18276

liviuconcioiu opened this issue Mar 19, 2023 · 3 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone
5.2.2

Comments

@liviuconcioiu
Copy link
Contributor

Describe the bug

on update CURRENT_TIMESTAMP doesn't show as default on attributes select.

To Reproduce

Steps to reproduce the behavior:

  1. Have a column with on update CURRENT_TIMESTAMP
  2. Edit that column
  3. See the attribute not selected as default.

Expected behavior

on update CURRENT_TIMESTAMP should be selected as default, if this attribute is present for that column.

Screenshots

19.03.2023_03.25.06_REC.mp4

Server configuration

  • phpMyAdmin version: 5.2.2-dev, 6.0.0-dev
@williamdes williamdes added Bug A problem or regression with an existing feature affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Mar 20, 2023
@williamdes williamdes added this to the 5.2.2 milestone Mar 20, 2023
@sfurqan2
Copy link
Contributor

sfurqan2 commented Apr 2, 2023

I think this issue has been fixed, unable to reproduce it. @liviuconcioiu

@liviuconcioiu
Copy link
Contributor Author

I think this issue has been fixed, unable to reproduce it. @liviuconcioiu

Isn't fixed. Try and change col. You will see the attribute not selected.

CREATE TABLE `test` (
  `id` int(11) NOT NULL,
  `col` timestamp NOT NULL ON UPDATE CURRENT_TIMESTAMP
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;

@sfurqan2
Copy link
Contributor

sfurqan2 commented Apr 2, 2023

Oh yes it is reproducing, I was trying it on MariaDb, my bad.

@M393 M393 mentioned this issue Feb 15, 2024
Merged
@williamdes williamdes self-assigned this Apr 28, 2024
@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete and removed affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Apr 28, 2024
williamdes added a commit that referenced this issue Apr 28, 2024
@williamdes
Add a ChangeLog entry for #18276
a2ae0e7 
Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Milestone
5.2.2
Development

No branches or pull requests
3 participants
@williamdes @liviuconcioiu @sfurqan2