Contest-2 Show index information in the data dict.

[pma-import]

attached is the patch.

---

• Original URL: https://sourceforge.net/p/phpmyadmin/patches/729/
• Original author: hiddenpearls

[pma-import]

• assigned_to: nobody --> lem9

---

• Original author: lem9

[pma-import]

Thanks for the patch, but I cannot accept it.

There is code duplication with other parts of the code which already display the index information in other pages.

---

• Original author: lem9

[pma-import]

• status: open --> pending-rejected

---

• Original author: lem9

[pma-import]

hey @lem9
I was sick and couldn't reply on my patch. I'm just back to my routine. I will reply about this patch soon.

---

• Original author: hiddenpearls

[pma-import]

another try, code is not duplicated now

---

• Original author: hiddenpearls
• Attachment: http://sourceforge.net/p/phpmyadmin/patches/_discuss/thread/e090b7ee/bb32/attachment/5726-Contest-2-Display-Indexes-information-in-data-dictio.patch

[pma-import]

Please have a look at code now. It is not duplicated.

---

• Original author: hiddenpearls

[pma-import]

• status: pending-rejected --> open-rejected

---

• Original author: lem9

[pma-import]

This is better, but

1. please provide a patch that applies to current master
2. avoid showing the index section for a table that has no index

---

• Original author: lem9

[pma-import]

• status: open-rejected --> open

---

• Original author: lem9

[pma-import]

1. please provide a patch that applies to current master
   ok will do it

2. avoid showing the index section for a table that has no index
   Currently it shows index section and displays that "No index defined!"
   We shouldn't show this ?

---

• Original author: hiddenpearls

[pma-import]

About #2, indeed it takes unnecessary room in the report.

---

• Original author: lem9

[pma-import]

From ee75ab459e86915b2a0dff794c8ad6b404c564b0 Mon Sep 17 00:00:00 2001
From: Muhammad Adnan <hiddenpearls@gmail.com>
Date: Thu, 22 Mar 2012 23:01:14 +0500
Subject: [PATCH] Contest-2: Show indexes information in data dictionary

---

db_datadict.php | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/db_datadict.php b/db_datadict.php
index e57206f..46f4b80 100644
--- a/db_datadict.php
+++ b/db_datadict.php
@@ -22,7 +22,7 @@ if (! isset($selected_tbl)) {
$cfgRelation = PMA_getRelationsParam();

require_once 'libraries/transformations.lib.php';

+require_once 'libraries/Index.class.php';

/**

• Check parameters
  @@ -262,6 +262,12 @@ foreach ($tables as $table) {
  $count++;
  ?>
  </table>
  +<?php
  +// display indexes information
  • if(count(PMA_Index::getFromTable($table, $db))>0){

  •    echo PMA_Index::getView($table, $db,true);
    

  • }
    +?>
    </div>
    <?php
    } //ends main while
    --
    1.7.5.4

---

• Original author: lem9

[pma-import]

Your patch was merged in the repository, thanks.

---

• Original author: lem9

[pma-import]

• summary: Contest-2 Show index information in the data dictionary --> (ok 4.0) Contest-2 Show index information in the data dict.
• priority: 5 --> 1
• status: open --> open-accepted

---

• Original author: lem9

[pma-import]

• Status: open-accepted --> closed-fixed

---

• Original author: nijel