Fixes #12361 and #12360 - Self XSS #12369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 52.68%@@ master #12369 diff @@
==========================================
Files 470 470
Lines 79530 79536 +6
Methods 2106 2106
Messages 0 0
Branches 0 0
==========================================
+ Hits 41901 41902 +1
- Misses 37629 37634 +5
Partials 0 0
|
Signed-off-by: Raghuram Vadapalli <raghuram.vadapalli@research.iiit.ac.in>
| { | ||
| return Util::backquote($val); | ||
| }, $GLOBALS[$current_grant[0]]); | ||
| } |
There was a problem hiding this comment.
Given you're manipulating globals here, how do you ensure this doesn't happen twice?
|
Closing as this is not ready for merge:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull request, please check that every commit:
Signed-off-by: Raghuram Vadapalli raghuram.vadapalli@research.iiit.ac.in