Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12651: Allow for all MySQL-allowed Date values #12666

Merged
merged 4 commits into from Nov 8, 2016

Conversation

devenbansod
Copy link
Member

@devenbansod devenbansod commented Oct 26, 2016

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Allow for partial dates on table insert page.
While grid editing on Browse page, close the datepicker ui if the date is invalid according to the datepicker but is allowed by MySQL.

Fix #12651

…dit Row link)

Issue phpmyadmin#12651

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
There are partial dates like '0000-00-00', '2016-00-00' etc. which are
rejected by the Datetimepicker JQuery plugin, but can be accepted by MySQL server

Fix phpmyadmin#12651

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@codecov-io
Copy link

codecov-io commented Oct 26, 2016

Current coverage is 50.18% (diff: 0.00%)

No coverage report found for QA_4_6 at 9e0e8a4.

Powered by Codecov. Last update 9e0e8a4...95c23da

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@nijel nijel self-assigned this Nov 8, 2016
@nijel nijel added this to the 4.6.5 milestone Nov 8, 2016
nijel added a commit that referenced this pull request Nov 8, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel nijel merged commit 95c23da into phpmyadmin:QA_4_6 Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants