Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a work around for testing if numRecords at least N #12685

Merged
merged 1 commit into from Nov 9, 2016

Conversation

devenbansod
Copy link
Member

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Fix #12257

The reporter has given a positive review regarding improvement in performance on large tables at #12257 (comment).

Signed-off-by: Deven Bansod devenbansod.bits@gmail.com

Fix phpmyadmin#12257

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@codecov-io
Copy link

Current coverage is 50.19% (diff: 88.00%)

Merging #12685 into QA_4_6 will increase coverage by 0.01%

@@             QA_4_6     #12685   diff @@
==========================================
  Files           485        485          
  Lines         81349      81371    +22   
  Methods        2126       2127     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          40823      40846    +23   
+ Misses        40526      40525     -1   
  Partials          0          0          

Powered by Codecov. Last update 583304a...1f439a4

@nijel nijel self-assigned this Nov 9, 2016
@nijel nijel added this to the 4.6.5 milestone Nov 9, 2016
@nijel nijel merged commit 1f439a4 into phpmyadmin:QA_4_6 Nov 9, 2016
nijel added a commit that referenced this pull request Nov 9, 2016
Signed-off-by: Michal Čihař <michal@cihar.com>
devenbansod added a commit that referenced this pull request Nov 10, 2016
…olumn

Required at some specific places for ex. browse_foreigners.php (reqd for pagination)
This is in continuation of original fix for #12257 (in #12685)

Also fixed an error in an old commit 9880f57
related to LIMIT clause generation

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
@devenbansod devenbansod deleted the fix_12257_wa branch November 10, 2016 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants