Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing punctuation #12686

Closed
wants to merge 1 commit into from
Closed

Missing punctuation #12686

wants to merge 1 commit into from

Conversation

lem9
Copy link
Contributor

@lem9 lem9 commented Nov 8, 2016

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@codecov-io
Copy link

codecov-io commented Nov 8, 2016

Current coverage is 54.28% (diff: 0.00%)

No coverage report found for master at d7a74c2.

Powered by Codecov. Last update d7a74c2...b2c0bbe

@nijel nijel self-assigned this Nov 9, 2016
nijel added a commit that referenced this pull request Nov 9, 2016
See PR #12686

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel nijel added this to the 4.6.5 milestone Nov 9, 2016
@nijel
Copy link
Contributor

nijel commented Nov 9, 2016

Thanks Marc for pointing this out. Your commit is missing signed-off-by and there are more occurrences of this, so I've fixed this in 7270a0c.

@nijel nijel closed this Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants